X-Recipient:	archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status:	No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL
X-Spam-Check-By:	sourceware.org
Message-ID:	<32703126.post@talk.nabble.com>
Date:	Sat, 22 Oct 2011 14:35:46 -0700 (PDT)
From:	"jan.kolar" <kolar AT math DOT cas DOT cz>
To:	cygwin AT cygwin DOT com
Subject:	(CVS) SH_USER_SHAREDplus allocation
MIME-Version:	1.0
X-IsSubscribed:	yes
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

http://cygwin.com/ml/cygwin-cvs/2011-q2/msg00196.html
introduced reordering of SH_- related memory blocks and the following change 

|   -	  unsigned size = offsets[i + 1] - offsets[i];
|   +	  unsigned size = offsets[i] - offsets[i + 1];
|    	  offsets[i] += delta;
|    	  if (!VirtualAlloc (off_addr (i), size, MEM_RESERVE, PAGE_NOACCESS))

However, address range is to be allocated using its LOWER boundary
which is now offsets[i + 1].

Even prior the change, I wondered why member[1] is not also updated.
Hence I also suggest that the allocation of [0], [1] and the last item 
should be double checked and perhaps commented in src.
|          for (int i = SH_USER_SHARED + 1; i < SH_TOTAL_SIZE; i++) 
"SH_USER_SHARED"+ 1 turns out to be 2.


|    	    continue;  /* oh well */
 :-)
-- 
View this message in context: http://old.nabble.com/%28CVS%29--SH_USER_SHAREDplus--allocation-tp32703126p32703126.html
Sent from the Cygwin list mailing list archive at Nabble.com.


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -