X-Recipient:	archive-cygwin AT delorie DOT com
X-Spam-Check-By:	sourceware.org
Date:	Wed, 12 Oct 2011 16:21:03 +0200
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: pressing ENTER scrambles scrolled MS-DOS-console
Message-ID:	<20111012142102.GA11150@calimero.vinschen.de>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<000c01cc7c46$615cd310$24167930$@de> <20111004123059 DOT GB27229 AT calimero DOT vinschen DOT de> <32593677 DOT post AT talk DOT nabble DOT com> <20111005023229 DOT GA1955 AT ednor DOT casa DOT cgf DOT cx>
MIME-Version:	1.0
In-Reply-To:	<20111005023229.GA1955@ednor.casa.cgf.cx>
User-Agent:	Mutt/1.5.21 (2010-09-15)
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Unsubscribe:	<mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

On Oct  4 22:32, Christopher Faylor wrote:
> On Tue, Oct 04, 2011 at 06:18:33PM -0700, jan.kolar wrote:
> >
> >
> >Corinna Vinschen-2 wrote:
> >> 
> >> On Sep 26 14:18, Paul Maier wrote:
> >>> Hi,
> >>> 
> >>> scrolling up the console output to review the console history, then
> >>> pressing
> >>> Enter scrambles the console.
> >> 
> >> That's a long standing behaviour of the Cygwin console emulation.
> >> I guess it can be fixed, but somebody will have to do it.  In the
> >> meantime, try mintty as terminal.
> >> 
> >> 
> >> Corinna
> >> 
> >> -- 
> >> Corinna Vinschen                  Please, send mails regarding Cygwin to
> >> Cygwin Project Co-Leader          cygwin AT cygwin DOT com
> >> Red Hat
> >> 
> >> 
> >
> >The problem is as below.
> >However it needs some thinking, checking and testing, since I have no idea
> >what that line was needed for.
> >
> >diff --git i/fhandler_console.cc w/fhandler_console.cc
> >index 74b5cbd..f29426d 100644
> >--- i/fhandler_console.cc
> >+++ w/fhandler_console.cc
> >@@ -1089,7 +1127,27 @@ fhandler_console::cursor_set (bool rel_to_top, int x,
> >int y)
> >
> >   dev_state->fillin_info (get_output_handle ());
> >   if (y > dev_state->info.winBottom)
> >-    y = dev_state->info.winBottom;
> >+    y = y;
> 
> Yeah.  Yeah.  Nice.

I applied a matching patch.  I tested this with various command line
and ncurses applications, and I didn't find any case where the behaviour
was worse than before.  In contrast, scrolling back to the old cursor
position on output is much more intuitive than the old behaviour.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -