X-Recipient:	archive-cygwin AT delorie DOT com
X-Spam-Check-By:	sourceware.org
Date:	Wed, 20 Jul 2011 17:46:47 +0200
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: ioctl: FIONREAD and ENOTTY
Message-ID:	<20110720154647.GA15150@calimero.vinschen.de>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<1311149476 DOT 7796 DOT 50 DOT camel AT YAAKOV04>
MIME-Version:	1.0
In-Reply-To:	<1311149476.7796.50.camel@YAAKOV04>
User-Agent:	Mutt/1.5.21 (2010-09-15)
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Unsubscribe:	<mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

On Jul 20 03:11, Yaakov (Cygwin/X) wrote:
> On Linux, ioctl(2) returns several different errors[1]:
> 
> EBADF  d is not a valid descriptor.
> EFAULT argp references an inaccessible memory area.
> EINVAL Request or argp is not valid.
> ENOTTY d is not associated with a character special device.
> ENOTTY The specified request does not apply to the kind of object that
>        the descriptor d references.
> 
> In the case of FIONREAD, Cygwin doesn't seem to distinguish between
> EINVAL and ENOTTY, and this causes at least one major bug:
> 
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35536
> 
> I have patched GCJ and GNU classpath to work around it, but this really
> needs to be fixed in Cygwin itself.

Would this patch be sufficient?

Index: fhandler.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/fhandler.cc,v
retrieving revision 1.397
diff -u -p -r1.397 fhandler.cc
--- fhandler.cc	5 Jul 2011 12:02:10 -0000	1.397
+++ fhandler.cc	20 Jul 2011 15:46:40 -0000
@@ -1151,6 +1151,10 @@ fhandler_base::ioctl (unsigned int cmd, 
       set_nonblocking (*(int *) buf);
       res = 0;
       break;
+    case FIONREAD:
+      set_errno (ENOTTY);
+      res = -1;
+      break;
     default:
       set_errno (EINVAL);
       res = -1;


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -