X-Recipient:	archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status:	No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,T_TO_NO_BRKTS_FREEMAIL
X-Spam-Check-By:	sourceware.org
Date:	Fri, 1 Apr 2011 20:09:38 +0200
From:	David Sastre <d DOT sastre DOT medina AT gmail DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: [ANNOUNCEMENT] Updated base-files-4.0-6
Message-ID:	<20110401180938.GA5897@jethro.local.lan>
References:	<announce DOT 20110318184505 DOT GG10633 AT jethro DOT local DOT lan> <4D93C294 DOT 1090509 AT laposte DOT net> <4D93C4B7 DOT 1070505 AT laposte DOT net> <4D946471 DOT 40006 AT dronecode DOT org DOT uk>
MIME-Version:	1.0
In-Reply-To:	<4D946471.40006@dronecode.org.uk>
User-Agent:	Mutt/1.5.20 (2009-06-14)
X-IsSubscribed:	yes
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Unsubscribe:	<mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

--fUYQa+Pmc3FrFX/N
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 31, 2011 at 12:24:33PM +0100, Jon TURNEY wrote:
> On 31/03/2011 01:03, Cyrille Lefevre wrote:
> > Le 31/03/2011 01:53, Cyrille Lefevre a =E9crit :
> >> Le 18/03/2011 19:45, David Sastre a =E9crit :
> >>> Version 4.0-6 of base-files has been uploaded.
> >>>
> >>> Base-files is a set of system configuration and setup files.
> >=20
> > Hi,
> >=20
> > PS1 *must not* be exported.
> >=20
> > historically, it is not exported to know if it is a shell is interactiv=
e or
> > not since only interactive shells set it.
> >=20
> > i.e., the following both solutions are equivalent.
> >=20
> > case $- in *i*) interactive ;; esac
> > [ -n $PS1 ] && interactive
> >=20
> > if PS1 is exported, it is always set for subshells and this may cause t=
rouble
> > in some script.
> >=20
> > also, from man bash :
> >=20
> > An  interactive  shell  is one started without non-option arguments and
> > without the -c option whose standard input and error are both connected
> > to  terminals  (as determined by isatty(3)), or one started with the -i
> > option.  PS1 is set and $- includes i if bash is interactive,  allowing
> > a shell script or a startup file to test this state.
>=20
> What the man page doesn't tell you is that bash actually unsets PS1 if the
> shell isn't interactive, so for bash at least, exporting PS1 can't cause a
> problem.

Hello,

Both improvements have been checked in for a future 4.0-7 version.
I'm waiting for dash to be updated to include also a simpler PRINTER
setting as you proposed.

--=20
Huella de clave primaria: 0FDA C36F F110 54F4 D42B  D0EB 617D 396C 448B 31EB

--fUYQa+Pmc3FrFX/N
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk2WFOIACgkQYX05bESLMevU4QCeM9hAjLc5Ob1ruBZt+0U8DHSC
mewAn37RLc99XmWh6mJPIU1QU0aEK4mx
=BuY0
-----END PGP SIGNATURE-----

--fUYQa+Pmc3FrFX/N--

- Raw text -