X-Recipient:	archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status:	No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW
X-Spam-Check-By:	sourceware.org
Message-ID:	<4C7FA8CB.4030207@dronecode.org.uk>
Date:	Thu, 02 Sep 2010 14:38:19 +0100
From:	Jon TURNEY <jon DOT turney AT dronecode DOT org DOT uk>
User-Agent:	Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.9) Gecko/20100825 Thunderbird/3.1.3
MIME-Version:	1.0
To:	cygwin AT cygwin DOT com
Subject:	Re: can't compile setup.exe
References:	<AANLkTinwYoXusghmJKt1VEk18JU3_v_QB2kwyDocrm3_ AT mail DOT gmail DOT com> <AANLkTindaBs0p_=_B0z5WphyvBofm5OHpBWp5i5kr1=i AT mail DOT gmail DOT com>
In-Reply-To:	<AANLkTindaBs0p_=_B0z5WphyvBofm5OHpBWp5i5kr1=i@mail.gmail.com>
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

--------------010108050503010805040807
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 02/09/2010 06:42, Andy Koppe wrote:
> On 2 September 2010 05:18, Vasya Pupkin wrote:
>> I'm trying to compile setup.exe from source code I got from CVS.
>
> Great!
>
>> For some reason, I am getting an error:
>>
>> propsheet.cc: In member function `bool PropSheet::SetActivePage(int)':
>> propsheet.cc:444: error: expected id-expression before '::' token
>> propsheet.cc:444: error: expected `)' before '::' token
>> propsheet.cc:444: error: expected `;' before '::' token
>> propsheet.cc:444: error: expected `;' before ')' token
>> propsheet.cc: In member function `bool PropSheet::SetActivePageByID(int)':
>> propsheet.cc:452: error: expected id-expression before '::' token
>> propsheet.cc:452: error: expected `)' before '::' token
>> propsheet.cc:452: error: expected `;' before '::' token
>> propsheet.cc:452: error: expected `;' before ')' token
>> propsheet.cc: In member function `void PropSheet::SetButtons(DWORD)':
>> propsheet.cc:459: error: expected id-expression before '::' token
>> propsheet.cc:459: error: expected `;' before '::' token
>> propsheet.cc: In member function `void PropSheet::PressButton(int)':
>> propsheet.cc:465: error: expected id-expression before '::' token
>> propsheet.cc:465: error: expected `;' before '::' token
>> make[2]: *** [propsheet.o] Error 1
>>
>> I did not touch this file. I installed all required packages and
>> followed instruction in README file.
>
> Hmm, newly fails for me too, and I can't work out why, given that the
> line in question is ancient code. I configured thusly:
>
> ./configure -C --disable-shared --host=i686-pc-mingw32
> --build=i686-pc-cygwin CC="gcc-3 -mno-cygwin" CXX="g++-3 -mno-cygwin"

This was broken by the recent w32api-3.15 update, which seems to have made 
those PropSheet macros C++ aware, so the global scoping operator is no longer 
needed.

Patch attached to fix it, but I couldn't work out how to also get it to build 
with w32api-3.14.

--------------010108050503010805040807
Content-Type: text/plain;
 name="setup_fix_build_with_latest_w32api.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="setup_fix_build_with_latest_w32api.patch"

SW5kZXg6IHByb3BzaGVldC5jYwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD
UyBmaWxlOiAvY3ZzL2N5Z3dpbi1hcHBzL3NldHVwL3Byb3BzaGVldC5jYyx2
CnJldHJpZXZpbmcgcmV2aXNpb24gMi4xNQpkaWZmIC11IC1yMi4xNSBwcm9w
c2hlZXQuY2MKLS0tIHByb3BzaGVldC5jYwkzMCBKdW4gMjAwOSAwNDoxNDoy
OSAtMDAwMAkyLjE1CisrKyBwcm9wc2hlZXQuY2MJMjkgQXVnIDIwMTAgMDk6
NTE6MTMgLTAwMDAKQEAgLTQ0MSw3ICs0NDEsNyBAQAogUHJvcFNoZWV0OjpT
ZXRBY3RpdmVQYWdlIChpbnQgaSkKIHsKICAgLy8gUG9zdHMgYSBtZXNzYWdl
IHRvIHRoZSBtZXNzYWdlIHF1ZXVlLCBzbyB0aGlzIHdvbid0IGJsb2NrCi0g
IHJldHVybiBzdGF0aWNfY2FzdCA8IGJvb2wgPiAoOjpQcm9wU2hlZXRfU2V0
Q3VyU2VsIChHZXRIV05EICgpLCBOVUxMLCBpKSk7CisgIHJldHVybiBzdGF0
aWNfY2FzdCA8IGJvb2wgPiAoUHJvcFNoZWV0X1NldEN1clNlbCAoR2V0SFdO
RCAoKSwgTlVMTCwgaSkpOwogfQogCiBib29sCkBAIC00NDksMTggKzQ0OSwx
OCBAQAogewogICAvLyBQb3N0cyBhIG1lc3NhZ2UgdG8gdGhlIG1lc3NhZ2Ug
cXVldWUsIHNvIHRoaXMgd29uJ3QgYmxvY2sKICAgcmV0dXJuIHN0YXRpY19j
YXN0IDwgYm9vbCA+Ci0gICAgKDo6UHJvcFNoZWV0X1NldEN1clNlbEJ5SUQg
KEdldEhXTkQgKCksIHJlc291cmNlX2lkKSk7CisgICAgKFByb3BTaGVldF9T
ZXRDdXJTZWxCeUlEIChHZXRIV05EICgpLCByZXNvdXJjZV9pZCkpOwogfQog
CiB2b2lkCiBQcm9wU2hlZXQ6OlNldEJ1dHRvbnMgKERXT1JEIGZsYWdzKQog
ewogICAvLyBQb3N0cyBhIG1lc3NhZ2UgdG8gdGhlIG1lc3NhZ2UgcXVldWUs
IHNvIHRoaXMgd29uJ3QgYmxvY2sKLSAgOjpQcm9wU2hlZXRfU2V0V2l6QnV0
dG9ucyAoR2V0SFdORCAoKSwgZmxhZ3MpOworICBQcm9wU2hlZXRfU2V0V2l6
QnV0dG9ucyAoR2V0SFdORCAoKSwgZmxhZ3MpOwogfQogCiB2b2lkCiBQcm9w
U2hlZXQ6OlByZXNzQnV0dG9uIChpbnQgYnV0dG9uKQogewotICA6OlByb3BT
aGVldF9QcmVzc0J1dHRvbiAoR2V0SFdORCAoKSwgYnV0dG9uKTsKKyAgUHJv
cFNoZWV0X1ByZXNzQnV0dG9uIChHZXRIV05EICgpLCBidXR0b24pOwogfQo=


--------------010108050503010805040807
Content-Type: text/plain; charset=us-ascii

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
--------------010108050503010805040807--

- Raw text -