X-Recipient:	archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status:	No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By:	sourceware.org
Message-ID:	<4C29FB20.6070006@redhat.com>
Date:	Tue, 29 Jun 2010 07:54:40 -0600
From:	Eric Blake <eblake AT redhat DOT com>
User-Agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.2 Thunderbird/3.0.5
MIME-Version:	1.0
To:	cygwin AT cygwin DOT com
Subject:	Re: Regression in .exe extension handling
References:	<1277766496 DOT 7412 DOT 18 DOT camel AT YAAKOV04> <4C292D35 DOT 6000005 AT redhat DOT com> <1277780070 DOT 7412 DOT 231 DOT camel AT YAAKOV04> <20100629084337 DOT GA8163 AT calimero DOT vinschen DOT de>
In-Reply-To:	<20100629084337.GA8163@calimero.vinschen.de>
X-IsSubscribed:	yes
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

--------------enig4FE6DA9E1E524C8156400D84
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 06/29/2010 02:43 AM, Corinna Vinschen wrote:
>> It's definitely a bug (or two) somewhere:
>>
>> * "install foo" correctly installs 'foo' but the presence of foo.exe
>> apparently fools something to add the .exe.
>>
>> * the .exe is being added when the file is clearly not a PE executable,
>> nor a link thereto.
>>
>> Whether these bugs are coming from coreutils or cygwin, or both, I do
>> not know.
>=20
> It doesn't look like a problem in Cygwin.  Strace shows there's an
> open("bar/foo.exe") call to create the file.
>=20
> I assume it's the logic in install along the lines of
>=20
>   stat("foo") shows that "foo" exists?
>   yes -> stat("foo.exe") shows that "foo.exe" exists?
>          yes -> so the original file is called "foo.exe".
>=20
> Maybe the test should check for the entire struct stat to be identical
> before making this decision?  Just an idea...

Most likely, the hole is in coreutils' exe magic.  Looks like I'll be
working on a coreutils-8.5-3 today...

--=20
Eric Blake   eblake AT redhat DOT com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


--------------enig4FE6DA9E1E524C8156400D84
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQEcBAEBCAAGBQJMKfsgAAoJEKeha0olJ0NqR3EH/Ahtl8p4yL0KicOkkOFVkSoe
i5MabnHe/pnCwEXsz7xBtK0IHel2JqED57kpfM7+XXEsTWt10LyVpdontbtidgKx
BaNm9i8b0C3Hmg8ohRICNL42xxDJ4wrhWi3w4J3+asrbnfcYOym04T6xd376f1fc
2p/gBJ46F/m8M2/Aiu11mnFT7yvx/MdnKnuqwogM6iczDZpqzdUp7AzTn0cx48cM
ApEY/aH9JKO8eXf/SK92RYeBL2f8FYjvLqnPbd2LMQ3u6RkToiXD/814BXnwcDCX
2LgCK6lzE15gN4KsELIc7w5GLOQjTqHiHgvnXPPbtdhiyx0+t8XZdNmT9BaeoXQ=
=NF2b
-----END PGP SIGNATURE-----

--------------enig4FE6DA9E1E524C8156400D84--

- Raw text -