X-Recipient:	archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status:	No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By:	sourceware.org
Message-ID:	<4BF2A806.9030603@redhat.com>
Date:	Tue, 18 May 2010 08:45:26 -0600
From:	Eric Blake <eblake AT redhat DOT com>
User-Agent:	Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Lightning/1.0b1 Mnenhy/0.8.2 Thunderbird/3.0.4
MIME-Version:	1.0
To:	cygwin AT cygwin DOT com
Subject:	Re: vfork always fail problem
References:	<AANLkTik_jo0N1YtUTFLzsqAsv5OkkyjCG9epeMq55bWk AT mail DOT gmail DOT com> <op DOT vcop6qoo1e62zd AT merlin DOT emma DOT line DOT org> <AANLkTikoAoUAarNLwuIHe6GypKg62rjKR1VPyQYygT17 AT mail DOT gmail DOT com> <20100514192202 DOT GB8785 AT calimero DOT vinschen DOT de> <u1vd9ahgy DOT fsf AT acm DOT org> <20100518143136 DOT GB5909 AT ednor DOT casa DOT cgf DOT cx>
In-Reply-To:	<20100518143136.GB5909@ednor.casa.cgf.cx>
X-IsSubscribed:	yes
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

--------------enigD54A37159A47644DDE555C30
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 05/18/2010 08:31 AM, Christopher Faylor wrote:
>>
>> -      WCHAR corefile[strlen (p) + sizeof (".stackdump")];
>> +      WCHAR corefile[wcslen (p) + sizeof (L".stackdump")];
>                                     ^^^^^^^^^^^^^^^^^^^^^^
> No L" is needed here, AFAICT.
>
> I've checked this in, removing the L.

I had to think about that, so I'm replying to document my thoughts.  You
want either 'sizeof (".stackdump")' or 'sizeof (L".stackdump") / sizeof
WCHAR'; and since both give the same value, Chris' change is correct.

--=20
Eric Blake   eblake AT redhat DOT com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


--------------enigD54A37159A47644DDE555C30
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQEcBAEBCAAGBQJL8qgGAAoJEKeha0olJ0NqFwgH/0fgKh0l6KNS/7bAUqxIDzsr
QUKaF2viWpZYX+fLHMzjt1Wo464pGA032zPOe7RFYDXJL3KBCUh1owzpQTRu1Nqj
dQQaN03SKtJZwKl09+AIZJWJ0iDDtbu4b8EPyNwsCds4ZPxvROzlY47LSWT69Us7
cRAW9mddu3dcwRZr5vD+XOmYKZK/zfCzEu7pZX8gat/PisVfNR4tsFTiSulowFbW
TTfmga3MOGbHVPADyn0VbTzn6TqV4U0uROA5uoTQwjOP3hi62PwapU72c6opKczr
0/yMioaxOzPewqr3Uxu39JezDWdF/SET+fBrzKZmKlLhneDQsbgvSe/d0cnq9ZY=
=mRyb
-----END PGP SIGNATURE-----

--------------enigD54A37159A47644DDE555C30--

- Raw text -