delorie.com/archives/browse.cgi   search  
Mail Archives: cygwin/2010/04/27/10:06:34

X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
Date: Tue, 27 Apr 2010 16:06:19 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: Cygwin's GCC doesn't like this .sa_handler initialization for some reason
Message-ID: <20100427140619.GI1845@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <20100425113232 DOT GA11541 AT sbox> <4BD5C311 DOT 2060708 AT redhat DOT com> <4BD5E165 DOT 6070907 AT gmail DOT com> <20100427090516 DOT GA12365 AT calimero DOT vinschen DOT de> <4BD6ED8A DOT 4080403 AT redhat DOT com>
MIME-Version: 1.0
In-Reply-To: <4BD6ED8A.4080403@redhat.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Apr 27 07:58, Eric Blake wrote:
> On 04/27/2010 03:05 AM, Corinna Vinschen wrote:
> > Like this?  We are already using analog definitions in the socket header
> > files.
> 
> Yes, that looks right.
> 
> > 
> > Index: include/cygwin/signal.h
> > ===================================================================
> > RCS file: /cvs/src/src/winsup/cygwin/include/cygwin/signal.h,v
> > retrieving revision 1.18
> > diff -u -p -r1.18 signal.h
> > --- include/cygwin/signal.h	26 Feb 2010 05:43:50 -0000	1.18
> > +++ include/cygwin/signal.h	27 Apr 2010 07:23:05 -0000
> > @@ -194,14 +194,16 @@ typedef void (*_sig_func_ptr)(int);
> >  
> >  struct sigaction
> >  {
> > -  __extension__ union
> > +  union
> >    {
> >      _sig_func_ptr sa_handler;  		/* SIG_DFL, SIG_IGN, or pointer to a function */
> >      void  (*sa_sigaction) ( int, siginfo_t *, void * );
> > -  };
> > +  } __sighandler_or_action;
> >    sigset_t sa_mask;
> >    int sa_flags;
> >  };
> > +#define sa_handler	__sighandler_or_action.sa_handler
> > +#define sa_sigaction	__sighandler_or_action.sa_sigaction
> 
> And while we're touching the file, we probably want to do similar
> treatment for struct siginfo_t: si_tid, si_overrun, si_sigval, si_value,
> si_status, si_utime, si_stime, and si_addr.

Does "we" mean you're going to provide a patch?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -


  webmaster     delorie software   privacy  
  Copyright © 2019   by DJ Delorie     Updated Jul 2019