X-Recipient:	archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status:	No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_52,SPF_SOFTFAIL
X-Spam-Check-By:	sourceware.org
Message-ID:	<4A65BCC9.1020002@byu.net>
Date:	Tue, 21 Jul 2009 07:04:09 -0600
From:	Eric Blake <ebb9 AT byu DOT net>
User-Agent:	Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.22) Gecko/20090605 Thunderbird/2.0.0.22 Mnenhy/0.7.6.666
MIME-Version:	1.0
To:	cygwin AT cygwin DOT com, newlib AT sources DOT redhat DOT com
Subject:	close on exec atomics
X-IsSubscribed:	yes
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

It seems like it would be pretty easy to add several new close-on-exec
features required by POSIX 2008:

open(name, O_RDONLY | O_CLOEXEC);
// skips the need to use fcntl

fcntl(fd, F_DUPFD_CLOEXEC);
// like F_DUPFD, but closes window without having to use
// fcntl(fd, F_SETFD, fcntl(fd, F_GETFD))

and those provided by glibc as extensions:

fopen(name, "re");
// like fopen "r", but with cloexec set

The argument is that in multi-threaded apps, if one thread opens a file
but has not yet turned on the close-on-exec bit while another thread does
a fork-and-exec, then you leaked the fd into the child; and these new
flags close the window.

Should I go ahead and prepare a patch for the newlib side?

- --
Don't work too hard, make some time for fun as well!

Eric Blake             ebb9 AT byu DOT net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkplvMkACgkQ84KuGfSFAYD+1ACfRInQJqHLu2v79zNU+1876TWv
an8AoLKXGav0FWdsPiauLd0d11rCfTtt
=KZci
-----END PGP SIGNATURE-----

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -