X-Recipient:	archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status:	No, hits=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By:	sourceware.org
To:	cygwin AT cygwin DOT com
From:	Eric Blake <ebb9 AT byu DOT net>
Subject:	Re: MVFS results
Date:	Fri, 17 Jul 2009 01:17:51 +0000 (UTC)
Lines:	28
Message-ID:	<loom.20090717T011618-309@post.gmane.org>
References:	<loom DOT 20090715T192219-408 AT post DOT gmane DOT org> <20090715204831 DOT GA27613 AT calimero DOT vinschen DOT de> <loom DOT 20090715T213245-387 AT post DOT gmane DOT org> <20090716090703 DOT GH27613 AT calimero DOT vinschen DOT de> <loom DOT 20090716T133741-21 AT post DOT gmane DOT org> <20090716151121 DOT GO27613 AT calimero DOT vinschen DOT de> <loom DOT 20090716T154525-611 AT post DOT gmane DOT org> <20090716165112 DOT GS27613 AT calimero DOT vinschen DOT de> <loom DOT 20090716T165527-559 AT post DOT gmane DOT org> <20090716174525 DOT GT27613 AT calimero DOT vinschen DOT de> <loom DOT 20090716T225222-72 AT post DOT gmane DOT org>
Mime-Version:	1.0
User-Agent:	Loom/3.14 (http://gmane.org/)
X-IsSubscribed:	yes
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

Eric Blake <ebb9 <at> byu.net> writes:

> Does the fact that MVFS is including the trailing NUL in fsname.Length, but 
> ro_u_mvfs is not, relevant to RtlEqualUnicodeString returning false, even 
> though the two Buffers are identical over their MaximumLength?
> 

Sure enough, your patch plus this one-liner is enough to make symlinks work on
MVFS once again!

diff --git i/winsup/cygwin/globals.cc w/winsup/cygwin/globals.cc
index ef17534..1cd6b19 100644
--- i/winsup/cygwin/globals.cc
+++ w/winsup/cygwin/globals.cc
@@ -89,7 +89,7 @@ UNICODE_STRING _RDATA ro_u_uncp = _ROU (L"\\??\\UNC\\");
 UNICODE_STRING _RDATA ro_u_mtx = _ROU (L"mtx");
 UNICODE_STRING _RDATA ro_u_csc = _ROU (L"CSC-CACHE");
 UNICODE_STRING _RDATA ro_u_fat = _ROU (L"FAT");
-UNICODE_STRING _RDATA ro_u_mvfs = _ROU (L"MVFS");
+UNICODE_STRING _RDATA ro_u_mvfs = _ROU (L"MVFS\0");
 UNICODE_STRING _RDATA ro_u_nfs = _ROU (L"NFS");
 UNICODE_STRING _RDATA ro_u_ntfs = _ROU (L"NTFS");
 UNICODE_STRING _RDATA ro_u_sunwnfs = _ROU (L"SUNWNFS");


-- 
Eric Blake



--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -