X-Recipient:	archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status:	No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By:	sourceware.org
Message-ID:	<49AD4174.6040906@gmail.com>
Date:	Tue, 03 Mar 2009 14:40:52 +0000
From:	Dave Korn <dave DOT korn DOT cygwin AT googlemail DOT com>
User-Agent:	Thunderbird 2.0.0.17 (Windows/20080914)
MIME-Version:	1.0
To:	Dave Korn <dave DOT korn DOT cygwin AT googlemail DOT com>
CC:	cygwin AT cygwin DOT com
Subject:	Re: [1.7] rebaseall doesn't solve the problem
References:	<499F6682 DOT 1090204 AT cwilson DOT fastmail DOT fm> <20090224100616 DOT GC6035 AT calimero DOT vinschen DOT de> <49A85971 DOT 6070300 AT cwilson DOT fastmail DOT fm> <20090228104337 DOT GG19887 AT calimero DOT vinschen DOT de> <49A986B4 DOT 2080501 AT cwilson DOT fastmail DOT fm> <20090228195127 DOT GA26646 AT ednor DOT casa DOT cgf DOT cx> <20090228202850 DOT GB8503 AT calimero DOT vinschen DOT de> <20090302120756 DOT GA31166 AT calimero DOT vinschen DOT de> <49ABF7B5 DOT 5010605 AT cwilson DOT fastmail DOT fm> <49AC56FE DOT 4080708 AT gmail DOT com> <49AC90A5 DOT 2080001 AT cwilson DOT fastmail DOT fm> <49AC9BAB DOT 9000700 AT gmail DOT com>
In-Reply-To:	<49AC9BAB.9000700@gmail.com>
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

Dave Korn wrote:
> 
>   Nope, should be easy to cut out the relevant bits, discarding ld-isms, and
> paste the remainder into your code.  Copy of WIP attached for your
> convenience; I've got to add doco and testcases before I can submit it, but
> the parsing stuff is ready to fly and I'd appreciate any extra testing it gets :)

  Two bugfixes FYI:

static void
set_pe_value_from_flags (char *name)

after
      /* Deliberately allow multiple conjoined separators.  */
      while (is_flag_sep (*optarg))
	optarg++;
add
      /* Even trailing at the end.  */
      if (!*optarg)
	break;

change
      /* If there's any more, we do insist on at least one separator.  */
      if (optarg && !is_flag_sep (*optarg))
to
      /* If there's any more, we do insist on at least one separator.  */
      if (*optarg && !is_flag_sep (*optarg))



    cheers,
      DaveK

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

- Raw text -