X-Recipient:	archive-cygwin AT delorie DOT com
X-Spam-Check-By:	sourceware.org
Message-ID:	<5b9751660806130248u6c955c2csf3b5988235b453f2@mail.gmail.com>
Date:	Fri, 13 Jun 2008 10:48:04 +0100
From:	"Will Palmer" <wmpalmer AT gmail DOT com>
To:	cygwin AT cygwin DOT com
Subject:	[PATCH] Bug in /usr/bin/cron-config (needs quotation marks)
MIME-Version:	1.0
X-IsSubscribed:	yes
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

------=_Part_29538_8717593.1213350484249
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

A couple of places in /usr/bin/cron-config (cron version 4.1-6) are
missing quotation marks around variables in tests, resulting in errors
when the username contains spaces.

Example errors:
------------------------------------------------
Do you want to install the cron daemon as a service? (yes/no) no
Running cron_diagnose ...
/usr/bin/cron-config: line 456: [: /var/cron/tabs/Will: binary operator expected
/usr/bin/cron-config: line 459: [: /var/cron/tabs/Will: binary operator expected
/usr/bin/cron-config: line 371: [: /var/cron/tabs/Will: binary operator expected
ls: cannot access /var/cron/tabs/Will Palmer: No such file or directory
cron table files need to writable only by the owner,
readable by the owner and he group, and executable by no one.
The permissions of your cron table file are set to:
ls: cannot access /var/cron/tabs/Will: No such file or directory
ls: cannot access Palmer: No such file or directory
------------------------------------------------


-- 
Will Palmer
wmpalmer AT gmail DOT com
(+44) 01303 245 210

------=_Part_29538_8717593.1213350484249
Content-Type: application/octet-stream; name=cron-config.p
Content-Transfer-Encoding: base64
X-Attachment-Id: f_fhelici70
Content-Disposition: attachment; filename=cron-config.p

LS0tIC91c3IvYmluL2Nyb24tY29uZmlnLm9sZAkyMDA4LTA2LTEzIDEwOjIz
OjU5LjIzOTYzNTAwMCArMDEwMAorKysgL3Vzci9iaW4vY3Jvbi1jb25maWcJ
MjAwOC0wNi0xMyAxMDozNToxOS4zODAyNjAwMDAgKzAxMDAKQEAgLTM2OCw3
ICszNjgsNyBAQAogICAgIGNyb25fdGFibGU9Ii92YXIvY3Jvbi90YWJzLyR7
VVNFUn0iCiAgICAgY291bGRiZUZBVD0wCiAKLSAgICBpZiBbICEgLWYgJGNy
b25fdGFibGUgXTsgdGhlbgorICAgIGlmIFsgISAtZiAiJGNyb25fdGFibGUi
IF07IHRoZW4KIAllY2hvICJXQVJOSU5HOiBZb3VyIGNvbXB1dGVyIGRvZXMg
bm90IGFwcGVhciB0byBoYXZlIGEgY3JvbiB0YWJsZSBmb3IgJHtVU0VSfS4i
CiAJZWNobyAiUGxlYXNlIGdlbmVyYXRlIGEgY3JvbiB0YWJsZSBmb3IgJHtV
U0VSfSB1c2luZyAnY3JvbnRhYiAtZSciCiAJZWNobwpAQCAtMzgzLDcgKzM4
Myw3IEBACiAJZWNobyAiY3JvbiB0YWJsZSBmaWxlcyBuZWVkIHRvIHdyaXRh
YmxlIG9ubHkgYnkgdGhlIG93bmVyLCIKIAllY2hvICJyZWFkYWJsZSBieSB0
aGUgb3duZXIgYW5kIGhlIGdyb3VwLCBhbmQgZXhlY3V0YWJsZSBieSBubyBv
bmUuIgogCWVjaG8gIlRoZSBwZXJtaXNzaW9ucyBvZiB5b3VyIGNyb24gdGFi
bGUgZmlsZSBhcmUgc2V0IHRvOiIKLQlscyAtbCAkY3Jvbl90YWJsZQorCWxz
IC1sICIkY3Jvbl90YWJsZSIKIAllY2hvCiAJZWNobwogCWVjaG8gIllvdSBj
YW4gc2V0IHRoZSBmaWxlIHBlcm1pc3Npb25zIHdpdGg6IgpAQCAtNDAwLDcg
KzQwMCw3IEBACiAJLWEgIiR1c2VybmFtZSIgIT0gIiRVU0VSIiBdOyB0aGVu
CiAJZWNobyAiVGhlIGdyb3VwIG1lbWJlcnNoaXAgb2YgeW91ciBjcm9uIHRh
YmxlIGZpbGUgc2hvdWxkIGJlIEFETUlOSVNUUkFUT1JTLiIKIAllY2hvICJI
ZXJlIGlzIHlvdXIgY3JvbiB0YWJsZSBmaWxlIGxpc3Rpbmc6IgotCWxzIC1s
ICRjcm9uX3RhYmxlCisJbHMgLWwgIiRjcm9uX3RhYmxlIgogCWVjaG8KIAlb
ICIkY291bGRiZUZBVCIgPSAxIF0gJiYKIAllY2hvICJUaGlzIHJ1bGUgZG9l
cyBub3QgYXBwbHkgb24gRkFUL0ZBVDMyIGZpbGUgc3lzdGVtcy4iCkBAIC00
NTMsMTAgKzQ1MywxMCBAQAogCWVjaG8KIAlyZXQ9MQogICAgIGZpCi0gICAg
aWYgWyAhIC1lIC92YXIvY3Jvbi90YWJzLyR7VVNFUn0gXTsgdGhlbgorICAg
IGlmIFsgISAtZSAiL3Zhci9jcm9uL3RhYnMvJHtVU0VSfSIgXTsgdGhlbgog
CWVjaG8gIldBUk5JTkc6IFlvdSBkbyBub3QgY3VycmVudGx5IGhhdmUgYSBj
cm9udGFiIGZpbGUuIgogCWVjaG8KLSAgICBlbGlmIFsgISAtciAvdmFyL2Ny
b24vdGFicy8ke1VTRVJ9IF07IHRoZW4KKyAgICBlbGlmIFsgISAtciAiL3Zh
ci9jcm9uL3RhYnMvJHtVU0VSfSIgXTsgdGhlbgogCWVjaG8gIkVSUk9SOiBZ
b3VyIGNyb250YWIgZmlsZSBpcyBub3QgcmVhZGFibGUuIgogCWVjaG8KIAly
ZXQ9MQo=


------=_Part_29538_8717593.1213350484249
Content-Type: text/plain; charset=us-ascii

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/
------=_Part_29538_8717593.1213350484249--

- Raw text -