X-Spam-Check-By:	sourceware.org
Date:	Sun, 27 May 2007 12:08:33 -0400
From:	Christopher Faylor <cgf-use-the-mailinglist-please AT cygwin DOT com>
To:	cygwin AT cygwin DOT com, newlib AT sourceware DOT org
Subject:	Re: [patch] fix printf("%p") (lesstif / XPDF crash)
Message-ID:	<20070527160833.GB5451@ednor.casa.cgf.cx>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com, newlib AT sourceware DOT org
References:	<46598137 DOT 582DB937 AT dessent DOT net> <4659927B DOT 3040704 AT byu DOT net>
MIME-Version:	1.0
In-Reply-To:	<4659927B.3040704@byu.net>
Reply-Cc:	cygwin AT cygwin DOT com
User-Agent:	Mutt/1.5.14 (2007-02-12)
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Unsubscribe:	<mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

On Sun, May 27, 2007 at 08:15:23AM -0600, Eric Blake wrote:
>According to Brian Dessent on 5/27/2007 7:01 AM:
>> Currently sprintf("%p") does not work because the path taken for
>> handling %p shares most of the code with %x but fails to populate the
>> char ox[2] used to emit the prefix, resulting in two uninitialized
>> characters being written instead of 'Ox'.
>
>Sorry about that - I missed %p when I changed the logic of %x in order to
>add %a.  But your analysis is correct, and your patch looks correct too.
>Since I broke it, I'm checking in your patch as obvious.

...and I'm generating a new cygwin snapshot with the change.

Thanks Brian for tracking this down and thanks Eric for checking it in.

cgf

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

- Raw text -