X-Spam-Check-By:	sourceware.org
Message-ID:	<45E9B17A.5050304@portugalmail.pt>
Date:	Sat, 03 Mar 2007 17:33:46 +0000
From:	Pedro Alves <pedro_alves AT portugalmail DOT pt>
User-Agent:	Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.8.0.9) Gecko/20061207 Thunderbird/1.5.0.9 Mnenhy/0.7.4.0
MIME-Version:	1.0
To:	cygwin AT cygwin DOT com
Subject:	Re: missing definition of __STRING macro in standard cygwin headers
References:	<000001c75d7b$f1a52100$05ffa8c0 AT Hydrogen> <45E9A86E DOT 7030803 AT byu DOT net> <45E9AAD8 DOT 7D1A3AF3 AT dessent DOT net>
In-Reply-To:	<45E9AAD8.7D1A3AF3@dessent.net>
X-Antivirus:	avast! (VPS 000721-1, 03-03-2007), Outbound message
X-Antivirus-Status:	Clean
X-IsSubscribed:	yes
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

Brian Dessent wrote:
> Eric Blake wrote:
> Not to mention the fact that it's incredibly silly to rely on libc
> headers to define something as trivial as the stringify operator which
> is a standard part of the C language.  Does it also require
> __COMMENTBEGIN to be defined as /*?  __BRACEBEGIN as {?  Why not just
> use #x in the code in the first place?
>
>   
Because the stringify operator only works inside a #define?

> By the way, I don't see why you can't just build this package like:
>
> ./configure CPPFLAGS="-D__STRING=#x" ..rest of configure options..
>
>   
It wouldn't work.
#define __STRING #x != #define __STRING(x) #x

But I do agree with Eric.

Anyway, if chosen to change the FAAC side of the fence, instead of:

#ifdef __CYGWIN__
#define __STRING ...
#endif

It would be perhaps better to:

#ifndef __STRING
#define __STRING ...
#endif

Cheers,
Pedro Alves



--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

- Raw text -