X-Spam-Check-By:	sourceware.org
Message-ID:	<4544DC4F.5020908@cygwin.com>
Date:	Sun, 29 Oct 2006 11:52:31 -0500
From:	"Larry Hall (Cygwin)" <reply-to-list-only-lh AT cygwin DOT com>
Reply-To:	cygwin AT cygwin DOT com
User-Agent:	Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.7) Gecko/20060916 Fedora/1.5.0.7-1.fc4.remi Thunderbird/1.5.0.7 Mnenhy/0.7.4.0
MIME-Version:	1.0
To:	cygwin AT cygwin DOT com
Subject:	Re: Install failing and leaving unusable system
References:	<45448BF3 DOT 6060507 AT meridiandigital DOT co DOT uk>
In-Reply-To:	<45448BF3.6060507@meridiandigital.co.uk>
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

Julian Hall wrote:
> I know this has been discussed here before, but it seems that it's 
> something that happens to a lot of people, so it should probably be 
> fixed.  It seems as though a fairly simple update to the setup program 
> might be helpful to people who have the problem.  In script.cc, there 
> are currently lines that read:
> 
>  if (retval)
>    log(LOG_PLAIN) << "abnormal exit: exit code=" << retval << endLog;;
> 
>  /* if file exists then delete it otherwise just ignore no file error */
>  io_stream::remove ("cygfile://" + scriptName + ".done");
> 
>  io_stream::move ("cygfile://" + scriptName,
>                   "cygfile://" + scriptName + ".done");
> 
> I'd suggest changing them so that the destination filename in the case 
> of an abnormal exit is different (e.g. scriptName + ".failed").  A flag 
> could then be set so that a dialog box is shown at the end, stating that 
> errors occurred running the postinstall scripts, and directing users to 
> a simple shell script that can be run after rebooting, which will run 
> all the /etc/postinstall/*.failed scripts and move them to appropraite 
> ".done" names.
> 
> Does that sound like a sensible idea?


Sounds reasonable to me.  Want to create a patch for the maintainers to
review?

-- 
Larry Hall                              http://www.rfk.com
RFK Partners, Inc.                      (508) 893-9779 - RFK Office
216 Dalton Rd.                          (508) 893-9889 - FAX
Holliston, MA 01746

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

- Raw text -