X-Spam-Check-By:	sourceware.org
Date:	Wed, 20 Sep 2006 20:50:04 -0700
From:	Christopher Layne <clayne AT anodized DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: bash-3.1-7$B!!(BBUG
Message-ID:	<20060921035004.GD6790@ns1.anodized.com>
References:	<ee9oa9$sj$1 AT sea DOT gmane DOT org> <ee9q53$74g$1 AT sea DOT gmane DOT org> <loom DOT 20060913T234039-426 AT post DOT gmane DOT org> <ee9vg0$qeb$1 AT sea DOT gmane DOT org> <45089854 DOT 8010705 AT scytek DOT de> <20060914001902 DOT GB24899 AT trixie DOT casa DOT cgf DOT cx> <4508ABAF DOT 5090408 AT scytek DOT de> <20060914020737 DOT GC24899 AT trixie DOT casa DOT cgf DOT cx> <45093972 DOT 7080606 AT byu DOT net> <45098A3B DOT 4060105 AT scytek DOT de>
Mime-Version:	1.0
In-Reply-To:	<45098A3B.4060105@scytek.de>
User-Agent:	Mutt/1.5.11
X-Assp-Spam-Prob:	0.00000
X-Assp-Whitelisted:	Yes
X-Assp-Envelope-From:	clayne AT ns1 DOT anodized DOT com
X-Assp-Intended-For:	cygwin AT cygwin DOT com
X-IsSubscribed:	yes
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Unsubscribe:	<mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

On Thu, Sep 14, 2006 at 12:58:36PM -0400, Volker Quetschke wrote:
> > +#ifdef __CYGWIN__
> > +  /* lseek'ing on text files is problematic; lseek reports the true
> > +     file offset, but read collapses \r\n and returns a character
> > +     count.  We cannot reliably seek backwards if nr is smaller than
> > +     the seek offset encountered during the read, and must instead
> > +     treat the stream as unbuffered.  */
> > +  if ((bp->b_flag & (B_TEXT | B_UNBUFF)) == B_TEXT)
> ------------------------^^^^^^^^^^^^^^^^^      ^^^^^^
> part of the patch looks suspicious to me. You probably just want to test
> if the LHS expression is true.
> 
>   Volker

It's called a mask.

-cl

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

- Raw text -