X-Spam-Check-By:	sourceware.org
Message-ID:	<45098FB4.40703@scytek.de>
Date:	Thu, 14 Sep 2006 13:21:56 -0400
From:	Volker Quetschke <quetschke AT scytek DOT de>
User-Agent:	Thunderbird 1.5.0.5 (Windows/20060719)
MIME-Version:	1.0
To:	cygwin AT cygwin DOT com
Subject:	Re: bash-3.1-7$B!!(BBUG
References:	<004c01c6d821$68f5fdf0$a501a8c0 AT CAM DOT ARTIMI DOT COM>
In-Reply-To:	<004c01c6d821$68f5fdf0$a501a8c0@CAM.ARTIMI.COM>
X-IsSubscribed:	yes
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

--------------enig3DAF2EDF2C542390AB677729
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Dave Korn wrote:
> On 14 September 2006 17:59, Volker Quetschke wrote:
>=20
>> Hi!
>=20
>> (snip)
>>> +#ifdef __CYGWIN__
>>> +  /* lseek'ing on text files is problematic; lseek reports the true
>>> +     file offset, but read collapses \r\n and returns a character
>>> +     count.  We cannot reliably seek backwards if nr is smaller than
>>> +     the seek offset encountered during the read, and must instead
>>> +     treat the stream as unbuffered.  */
>>> +  if ((bp->b_flag & (B_TEXT | B_UNBUFF)) =3D=3D B_TEXT)
>> ------------------------^^^^^^^^^^^^^^^^^      ^^^^^^
>> part of the patch looks suspicious to me. You probably just want to test
>> if the LHS expression is true.
>=20
>   You reckon?  That looks to me like a test for B_TEXT is set *and* B_UNB=
UFF
> is cleared.  Since the action we're going to take if this test succeeds i=
s to
> set the stream unbuffered, there's no need to do it for a stream that alr=
eady
> /is/ unbuffered.  That's how it looks to me at first glance, anyway.

See, it was the lack of coffee ;) Sorry for the noise.

  Volker

(snap)

--=20
PGP/GPG key  (ID: 0x9F8A785D)  available  from  wwwkeys.de.pgp.net
key-fingerprint 550D F17E B082 A3E9 F913  9E53 3D35 C9BA 9F8A 785D


--------------enig3DAF2EDF2C542390AB677729
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (MinGW)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFCY+4PTXJup+KeF0RAlcMAKCCXv+z2qJz3ORk6tCz8jeEzUeuIgCfVZ+1
l6I+0SSss/GNjcOnkOK+5C8=
=B/td
-----END PGP SIGNATURE-----

--------------enig3DAF2EDF2C542390AB677729--

- Raw text -