Mail Archives: cygwin/2005/12/06/22:01:56
On Tue, 6 Dec 2005, Christopher Faylor wrote:
> On Tue, Dec 06, 2005 at 08:41:24PM -0500, Igor Pechtchanski wrote:
> >On Tue, 6 Dec 2005, Yitzchak Scott-Thoennes wrote:
> >[snip]
> >> That needs a comment in the code.
> >
> >Fair enough:
> >[snip]
> >+ /* Add two nulls to avoid confusing strtok() when the trailing separator
> >+ is missing */
>
> How about a testcase which shows that the MSVCRT strtok needs two
> trailing NUL bytes to work around problems when there is no trailing
> separator? I would find that much more interesting than a comment which
> simply asserts that behavior.
Fair enough. The double-null issue was a red herring, apparently -- a
simple recompile fixed the problem. In fact, the cygcheck from the latest
snapshot doesn't exhibit this behavior. Patch withdrawn.
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ pechtcha AT cs DOT nyu DOT edu
ZZZzz /,`.-'`' -. ;-;;,_ igor AT watson DOT ibm DOT com
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D.
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
If there's any real truth it's that the entire multidimensional infinity
of the Universe is almost certainly being run by a bunch of maniacs. /DA
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Problem reports: http://cygwin.com/problems.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/
- Raw text -