Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
To:	cygwin AT cygwin DOT com
From:	Franz Haeuslschmid <lukrez AT gmx DOT at>
Subject:	[Patch] EPS import for XFig
Date:	Wed, 05 Oct 2005 13:19:06 +0200
Lines:	47
Message-ID:	<di0cra$d4d$1@sea.gmane.org>
Mime-Version:	1.0
User-Agent:	Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.5-b22 (cucumber, windows-nt)
X-IsSubscribed:	yes

Hello,

there is a problem with XFig as soon as more than one EPS should
be imported as figure object.  It seems that only those users are
affected, that use a temporary directory on a NTFS partition.
The problem has been addressed earlier:

  <URL:http://article.gmane.org/gmane.os.cygwin.xfree/14757>

  <URL:http://thread.gmane.org/gmane.os.cygwin/40818>

and finally

  <URL:http://article.gmane.org/gmane.os.cygwin/69899>

An inspection of XFig's source code revealed that a call to
`unlink' in order to remove a temporary bitmap preview of the EPS
to include delays the actual deletion.  The bitmap preview for
subsequent EPS files would go to a temporary file always having
the same name.  As the deletion of the first preview is pending
(which means that the preview file is still there, without any
file permissions), subsequent previews having the same file name
can't be created and the import fails.

The cause for the delay of the deletion is, that there is still a
`FILE' object in memory that references that file.  The patch
forces the file to be closed as soon as it isn't needed any more.

Regards,
Franz.

2005-10-05  Franz Haeuslschmid  <lukrez AT gmx DOT at>

	* f_readeps.c (bitmap_from_gs): Ensures that all FILE objects
	referring to the temporary bitmap preview are closed before the
	preview file is unlinked.

--- f_readeps.c.orig	2005-10-05 11:17:05.985950000 +0200
+++ f_readeps.c	2005-10-05 11:19:29.095325000 +0200
@@ -407,6 +407,7 @@ Boolean
         ht = pic->pic_cache->size_y;
         pcxfile = open_picfile(pixnam, &filtyp, PIPEOK, tmpfile);
         status = _read_pcx(pcxfile, pic);
+        fclose(pcxfile);
         /* restore width/height */
         pic->pic_cache->size_x = wid;
         pic->pic_cache->size_y = ht;


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

- Raw text -