Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
From:	ericblake AT comcast DOT net (Eric Blake)
To:	cygwin AT cygwin DOT com
Cc:	Christopher Faylor <cgf-no-personal-reply-please AT cygwin DOT com>
Subject:	Re: Problem with sh/bash and snapshot cygwin1-20050825.dll
Date:	Fri, 26 Aug 2005 14:56:46 +0000
Message-Id:	<082620051456.7539.430F2DAE0006648800001D7322007613940A050E040D0C079D0A@comcast.net>
X-Authenticated-Sender:	ZXJpY2JsYWtlQGNvbWNhc3QubmV0

> On Fri, Aug 26, 2005 at 06:17:13AM -0600, Eric Blake wrote:
> >While you're at it, fix realpath(NULL, buf) to set buf[0]='\0', instead of
> >leaving garbage there.
> 
> What's the rationale for touching buf when realpath is returning an error
> and setting EINVAL?

Because POSIX states that buf is indeterminate on error, and
because Corrina's patch caused a regression (ie. 1.5.18 was
setting buf[0] to 0 on error).  QofI states that we might as
well make the indeterminate buffer useful, in case a user
forgets to check the return value being NULL.

--
Eric Blake



--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

- Raw text -