Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Date:	Sat, 28 May 2005 23:38:05 +0200 (CEST)
From:	Vaclav Haisman <V DOT Haisman AT sh DOT cvut DOT cz>
To:	cygwin AT cygwin DOT com
Subject:	fhandler_tty_slave::tcflush in fhandler_tty.cc
Message-ID:	<20050528232750.S63183@logout.sh.cvut.cz>
MIME-Version:	1.0
X-IsSubscribed:	yes
Reply-To:	cygwin AT cygwin DOT com

There is a similar problem to the one descibed in my previous post, this time
in fhandler_tty_slave::tcflush, line 1051: ret = len >= 0. This can never be
false, because len is unsigned. And it also seems wrong because tcflush()
should return either 0 on success or -1 on error. The way it is coded it will
return either 0 or 1. Maybe comparison to (size_t) -1 was intended instead?


VH.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

- Raw text -