Mail Archives: cygwin/2005/03/07/20:13:34
Hi Anthony, Chuck, all,
On 4-Mar-2005 4:21, Charles Wilson wrote:
> Anthony --
>
> I've applied this patch. Thanks!
Sorry for jumping in so late...
While I agree that the revised patch looks good and does the job, I'm
not too happy with the constant reallocation that's going on. (I know,
there won't be a measurable performance impact, but it, well, just looks
wring to me. ;-) )
In any case, here's a proposed alternative patch (against the version
containing Anthony's patch already) which calculates the actual total
argument size in advance, before allocating.
(In addition, I've taken the opportunity to change the listed email
address (cygwin_start at mscha dot org), which I had to block long ago
due to the ongoing stream of spam and viruses, to a new one, obscured
this time. Plus, I changed the feedback address to the mailing list
address (also obscured), since the list is obviously much more
responsive than I am. :-/ )
Chuck, if this looks OK to you, can you apply this patch?
Thanks, also to Anthony and all for everything you've done.
– Michael
PS: That free() bug was very embarrassing... :-[ (Hmm... why do I even
draw attention to that again? ;-) )
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Problem reports: http://cygwin.com/problems.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/
- Raw text -