delorie.com/archives/browse.cgi   search  
Mail Archives: cygwin/2005/02/02/13:42:08

Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Date: Wed, 2 Feb 2005 13:42:30 -0500
From: Christopher Faylor <cgf-no-personal-reply-please AT cygwin DOT com>
To: cygwin AT cygwin DOT com, newlib AT sources DOT redhat DOT com
Subject: Re: several more bugs found by coreutils
Message-ID: <20050202184230.GD18260@trixie.casa.cgf.cx>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com, newlib AT sources DOT redhat DOT com
References: <020120052058 DOT 2301 DOT 41FFED5A000D5EEC000008FD22007614380A050E040D0C079D0A AT comcast DOT net> <20050202100718 DOT GA7767 AT cygbert DOT vinschen DOT de> <4200DE19 DOT 70504 AT byu DOT net> <20050202142001 DOT GI31117 AT cygbert DOT vinschen DOT de> <20050202172040 DOT GL16117 AT trixie DOT casa DOT cgf DOT cx> <20050202174942 DOT GO31117 AT cygbert DOT vinschen DOT de> <20050202181358 DOT GA18260 AT trixie DOT casa DOT cgf DOT cx> <20050202183043 DOT GR31117 AT cygbert DOT vinschen DOT de>
Mime-Version: 1.0
In-Reply-To: <20050202183043.GR31117@cygbert.vinschen.de>
User-Agent: Mutt/1.4.1i

On Wed, Feb 02, 2005 at 07:30:43PM +0100, Corinna Vinschen wrote:
>On Feb  2 13:13, Christopher Faylor wrote:
>> On Wed, Feb 02, 2005 at 06:49:42PM +0100, Corinna Vinschen wrote:
>> >On Feb  2 12:20, Christopher Faylor wrote:
>> >> On Wed, Feb 02, 2005 at 03:20:01PM +0100, Corinna Vinschen wrote:
>> >> >  #if defined (__CYGWIN__) && !defined (__CYGWIN_USE_BIG_TYPES__)
>> >> >  #define __pw_uid_t int
>> >> >  #endif
>> >> >  #ifndef __pw_uid_t
>> >> >  #define __pw_uid_t uid_t;
>> >> >  #endif
>> >> >
>> >> >  struct passwd {
>> >> >    char *pw_name;
>> >> >    char *pw_passwd;
>> >> >    __pw_uid_t pw_uid;
>> >> >    __pw_gid_t pw_gid;
>> >> >    [etc].
>> >> >
>> >> >Would that be ok, Jeff?
>> >> 
>> >> Why not just make __pw_uid_t a typedef?
>> >
>> >Defined where?
>> 
>> In pwd.h:
>> 
>>   #ifndef __CYGWIN__ || !defined(__CYGWIN_USE_BIG_TYPES__)
>>   typedef int __pw_uid_t;
>>   #else
>>   typedef uid_t __pw_uid_t;
>>   endif
>
>Fine with me.  I don't see a difference, though.  What's the advantage
>of having another type?

It's a preference.  I don't like using defines for types. OTOH, you could
use a #undef after #define'ing the __pwd_uid_t and then there would be
no subsequent namespace bloat.

So, actually, nevermind.  I think I'd prefer a #define followed by a #undef
for that reason.

cgf

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

- Raw text -


  webmaster     delorie software   privacy  
  Copyright © 2019   by DJ Delorie     Updated Jul 2019