Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
X-VirusChecked:	Checked
X-Env-Sender:	okiddle AT yahoo DOT co DOT uk
X-Msg-Ref:	server-22.tower-36.messagelabs.com!1080810641!5097910
X-StarScan-Version:	5.2.10; banners=-,-,-
X-Originating-IP:	[158.234.9.163]
Cc:	zzapper <david AT tvis DOT co DOT uk>, zsh-workers AT sunsite DOT dk, cygwin AT cygwin DOT com
X-VirusChecked:	Checked
X-StarScan-Version:	5.0.7; banners=.,-,-
In-reply-to:	<Pine.LNX.4.53.0403310935450.9892@gremlin.fruitbat.org>
From:	Oliver Kiddle <okiddle AT yahoo DOT co DOT uk>
References:	<s38u10erwrz DOT fsf AT ackusativ DOT ling DOT uu DOT se> <1vvf60l9i7n4nlobcroik2le5ofe6v2rn4 AT 4ax DOT com> <Pine DOT LNX DOT 4 DOT 53 DOT 0403291441160 DOT 5939 AT gremlin DOT fruitbat DOT org> <3372 DOT 1080639122 AT trentino DOT logica DOT co DOT uk> <Pine DOT LNX DOT 4 DOT 53 DOT 0403301047250 DOT 5939 AT gremlin DOT fruitbat DOT org> <2603 DOT 1080737128 AT trentino DOT logica DOT co DOT uk> <Pine DOT LNX DOT 4 DOT 53 DOT 0403310935450 DOT 9892 AT gremlin DOT fruitbat DOT org>
To:	"Peter A. Castro" <doctor AT fruitbat DOT org>
Subject:	Re: zsh and line breaks
Date:	Thu, 01 Apr 2004 11:09:56 +0200
Message-ID:	<25057.1080810596@trentino.logica.co.uk>

"Peter A. Castro" wrote:
> > It is easy for us to add `#ifdef __CYGWIN__' around changes or #define
> > O_TEXT to zero on other systems so if you do correct the problem,
> > please send the changes back to us.
> 
> There are about 43 open() calls which I've updated with the O_TEXT
> option.  Having all those ifdef's seemed rather ugly (makes the code hard
> to look at, expectially when they are within a few lines of each other)
> so I took a more "elegent" approach, though you may want to revise it if
> it doesn't meet your style requirements :)

I can believe that adding ifdef's to all is ugly. That's what I meant
by "#define O_TEXT to zero on other systems" - just one thought on a
possible more "elegant" approach.

> Yep, I'm experimenting with this right now.  As it stands, tests which
> print out to a file and then cat it back in (currently A04redirect and
> E01options) produce a diff, but don't otherwise seem to have any
> problems.

Are the diffs just the line endings? From what I understand, the
reported problems were with text files used as input to the shell (i.e.
scripts, sourced files, autoloaded functions and stdin). Quite whether
it is also right for redirected output, I wouldn't know.

Oliver

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

- Raw text -