Mail Archives: cygwin/2004/01/28/19:39:39
---559023410-851401618-1075336706=:1236
Content-Type: TEXT/PLAIN; charset=US-ASCII
On Wed, 28 Jan 2004, Igor Pechtchanski wrote:
> [snip]
> A package search at <http://cygwin.com/packages/> for "bin/g\+\+.exe"
> should have found it, but there seems to be a bug (which I'm looking
> into) that truncates the match list before it displays "gcc-g++", which
> may have prompted this question.
Ok, I found the bug. The raw filename of the gcc-g++ package wasn't
quoted in the pattern. Since it contained '+'s, which are magic pattern
characters in perl, the pattern wasn't correct anyway. Since it contained
two of them in a row (and a regular character or construct is required
before a '+' in perl patterns), perl choked. The attached patch fixes
this. Permission to commit?
Igor
P.S. The same problem will happen (in a different place) if one searches
for 'g++'. There is a way to escape the '+'s in this case, though (by
searching for 'g\+\+' instead), and I don't think we want to disallow the
full RE searches just yet... Just in case, I have a patch ready for that,
too.
P.P.S. Should this have been sent to another list instead?
==============================================================================
ChangeLog:
2004-01-28 Igor Pechtchanski <pechtcha AT cs DOT nyu DOT edu>
* package-grep.cgi (findheader): Quote raw filename in pattern.
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ pechtcha AT cs DOT nyu DOT edu
ZZZzz /,`.-'`' -. ;-;;,_ igor AT watson DOT ibm DOT com
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D.
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster." -- Patrick Naughton
---559023410-851401618-1075336706=:1236
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="fix-broken-grep.patch"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine DOT GSO DOT 4 DOT 56 DOT 0401281938260 DOT 1236 AT slinky DOT cs DOT nyu DOT edu>
Content-Description:
Content-Disposition: attachment; filename="fix-broken-grep.patch"
SW5kZXg6IHBhY2thZ2UtZ3JlcC5jZ2kNCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0NClJDUyBmaWxlOiAvY3ZzL2N5Z3dpbi9odGRvY3MvY2dpLWJpbjIvcGFj
a2FnZS1ncmVwLmNnaSx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjYNCmRp
ZmYgLXUgLXAgLXIxLjI2IHBhY2thZ2UtZ3JlcC5jZ2kNCi0tLSBwYWNrYWdl
LWdyZXAuY2dpCTE1IE5vdiAyMDAxIDA3OjQ4OjM2IC0wMDAwCTEuMjYNCisr
KyBwYWNrYWdlLWdyZXAuY2dpCTI5IEphbiAyMDA0IDAwOjI1OjQ5IC0wMDAw
DQpAQCAtNjYsNiArNjYsNiBAQCBzdWIgYWRkZm4oJCkgew0KIA0KIHN1YiBm
aW5kaGVhZGVyIHsNCiAgICAgbXkgJHAgPSBzaGlmdDsNCi0gICAgbXkgJGhl
YWRlciA9ICgkX1swXSA9fiBtIV4uKjxhIGhyZWY9Lio/PiRwPC9hPi4qPzx0
ZC4qPz4oW14+PF0rKTwhbSlbMF07DQorICAgIG15ICRoZWFkZXIgPSAoJF9b
MF0gPX4gbSFeLio8YSBocmVmPS4qPz5cUSRwXEU8L2E+Lio/PHRkLio/Pihb
Xj48XSspPCFtKVswXTsNCiAgICAgcmV0dXJuICRoZWFkZXIgfHwgJyc7DQog
fQ0K
---559023410-851401618-1075336706=:1236
Content-Type: text/plain; charset=us-ascii
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Problem reports: http://cygwin.com/problems.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/
---559023410-851401618-1075336706=:1236--
- Raw text -