Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Message-ID:	<20040107125612.79544.qmail@web60301.mail.yahoo.com>
Date:	Wed, 7 Jan 2004 04:56:12 -0800 (PST)
From:	Patrick Samson <p_samson AT yahoo DOT com>
Subject:	tcl8.4.1 - tclWinInit - AppendEnvironment()
To:	cygwin AT cygwin DOT com
MIME-Version:	1.0

This function was designed at a time when the
parameter 'lib' was fed with a value such as
"lib/tclX.Y", so there is two times a "lib + 4"
pointer to extract the "tclX.Y" part.

But the value has changed to "share/tclX.Y" in
TclpInitLibraryPath(), and now lib + 4 points to
"/tclX.Y", which is of no use !

The caller and the calling should be accorded.
As "lib + a number" is a poor coding design (this
issue shows how fragile it is), I suggest to change it
entirely to a more robust one (RedHat/Cygwin people to
inform developers at sourceforge?).


I also have a doubt about this part of code, at the
end:
	} else {
	    objPtr = Tcl_NewStringObj(buf, -1);
	}
	Tcl_ListObjAppendElement(NULL, pathPtr, objPtr);

In my understanding, it means that the same object is
appended a second time. Am I wrong?


__________________________________
Do you Yahoo!?
Yahoo! Hotjobs: Enter the "Signing Bonus" Sweepstakes
http://hotjobs.sweepstakes.yahoo.com/signingbonus

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

- Raw text -