Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
X-Authentication-Warning:	slinky.cs.nyu.edu: pechtcha owned process doing -bs
Date:	Fri, 9 May 2003 10:14:38 -0400 (EDT)
From:	Igor Pechtchanski <pechtcha AT cs DOT nyu DOT edu>
Reply-To:	cygwin AT cygwin DOT com
To:	cygwin AT cygwin DOT com
Subject:	Re: cron allowed to interact with desktop ?
In-Reply-To:	<Pine.GSO.4.44.0305090955300.9872-200000@slinky.cs.nyu.edu>
Message-ID:	<Pine.GSO.4.44.0305091002121.9872-200000@slinky.cs.nyu.edu>
Importance:	Normal
MIME-Version:	1.0

---559023410-758783491-1052488692=:9872
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII
Content-ID: <Pine DOT GSO DOT 4 DOT 44 DOT 0305091002123 DOT 9872 AT slinky DOT cs DOT nyu DOT edu>

Corinna,

While we're at it, two more things (see below).

On Fri, 9 May 2003, Igor Pechtchanski wrote:

> FWIW, the previous patch failed because of a new flag (-Q) in CVS.

This has bitten me in the past, so I'm going to make a suggestion: why not
specify each flag in opts on a separate line, e.g.,

char *opts = "I:"
	"R:"
	"S:"
	"E:"
	"p:"
	"a:"
	"c:"
	"e:"
	"d:"
	"f:"
	"o"
	"u:"
	"w:"
	"t:"
	"s:"
	"y:"
	"0:"
	"1:"
	"2:"
	"i"
	"h"
	"v";

instead of

char *opts = "I:R:S:E:p:a:c:e:d:f:ou:w:t:s:y:0:1:2:ihv";

I know it doesn't look quite as compact (and consumes 2 extra bytes per
option -- the TAB and the NL), but it will ease patching considerably.

And another thing, I noticed there were some string constants in
cygrunsrv.h that had to be kept in sync with the numeric ones.  That kinda
rattled my sense of elegance (however much I have of it), so here's a
small patch (attached)...
	Igor
==============================================================================
2003-05-09  Igor Pechtchanski  <pechtcha AT cs DOT nyu DOT edu>

	* cygrunsrv.h: (STRINGIFY) New macro.
	(STRINGIFY_) New helper macro.
	(MAX_ENV_STR, MAX_DEPS_STR) Fix redundant string
	constants.

-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha AT cs DOT nyu DOT edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor AT watson DOT ibm DOT com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

Knowledge is an unending adventure at the edge of uncertainty.
  -- Leto II

---559023410-758783491-1052488692=:9872
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="cygrunsrv-stringify.patch"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine DOT GSO DOT 4 DOT 44 DOT 0305091014380 DOT 9872 AT slinky DOT cs DOT nyu DOT edu>
Content-Description: 
Content-Disposition: attachment; filename="cygrunsrv-stringify.patch"

SW5kZXg6IGN5Z3J1bnNydi5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpS
Q1MgZmlsZTogL2N2cy9jeWd3aW4tYXBwcy9jeWdydW5zcnYvY3lncnVuc3J2
Lmgsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjgNCmRpZmYgLXUgLXAgLXIx
LjggY3lncnVuc3J2LmgNCi0tLSBjeWdydW5zcnYuaAkyNiBGZWIgMjAwMiAx
MToyMjoyOSAtMDAwMAkxLjgNCisrKyBjeWdydW5zcnYuaAk5IE1heSAyMDAz
IDE0OjAxOjQ0IC0wMDAwDQpAQCAtMzcsMTEgKzM3LDE0IEBADQogI2RlZmlu
ZSBERUZfU1RESU5fUEFUSAkiL2Rldi9udWxsIg0KICNkZWZpbmUgREVGX0xP
R19QQVRICSIvdmFyL2xvZy8iDQogDQorI2RlZmluZSBTVFJJTkdJRllfKFgp
ICAgI1gNCisjZGVmaW5lIFNUUklOR0lGWShYKSAgICBTVFJJTkdJRllfKFgp
DQorDQogI2RlZmluZSBNQVhfRU5WCQkyNTUNCi0jZGVmaW5lIE1BWF9FTlZf
U1RSCSIyNTUiDQorI2RlZmluZSBNQVhfRU5WX1NUUglTVFJJTkdJRlkoTUFY
X0VOVikNCiANCiAjZGVmaW5lIE1BWF9ERVBTCTE2DQotI2RlZmluZSBNQVhf
REVQU19TVFIJIjE2Ig0KKyNkZWZpbmUgTUFYX0RFUFNfU1RSCVNUUklOR0lG
WShNQVhfREVQUykNCiANCiBleHRlcm4gY2hhciAqYXBwbmFtZTsNCiBleHRl
cm4gY2hhciAqc3ZjbmFtZTsNCg==

---559023410-758783491-1052488692=:9872
Content-Type: text/plain; charset=us-ascii

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/
---559023410-758783491-1052488692=:9872--

- Raw text -