Mail Archives: cygwin/2003/01/02/10:01:01
On Thu, Jan 02, 2003 at 10:23:56AM +0000, Steven O'Brien wrote:
> On Wed, 01 Jan 2003 18:39:08 -0500
> Charles Wilson <cwilson AT ece DOT gatech DOT edu> wrote:
>
> > Steven O'Brien wrote:
> > > My patch works around this problem by allocating a buffer of 1024
> > > bytes for cygwin. I think I got this value by reading the cygwin dll
> > > source to find a real upper bound, but it was a long time ago so
> > > this needs checking.
There is no enforced limit on the size of the gecos field, so there is
no guaranteed bound. However 1024 allows for large entries in that field
(300 to 400 bytes) even if all the other fields are at their max.
> > I saw this...it's probably a decent workaround, but hasn't yet been
> > accepted into current glib source AFAICT --- glib-2.2.0 still uses a
> > 64 byte buffer for reading pw entries. But that's not where the
> > segfault is happening in my case (as my earlier message showed).
>
> Just to be clear, I did not see any failure in this function either. But
> failures later (in gnome-vfs I think) were due to memory corruption
> which went away when I increased this buffer to 1024 bytes.
Cygwin won't overrun the buffer but returns an error if it's too short.
So if increasing the buffer length makes a difference, error handling
becomes suspect.
Pierre
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Bug reporting: http://cygwin.com/bugs.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/
- Raw text -