Mail Archives: cygwin/2002/12/29/01:18:17
On Sat, Dec 28, 2002 at 01:25:14AM -0500, Christopher Faylor wrote:
> Well, surprise, this bugged me enough that I had to track it down. The
> order of acceptance of input and echoing of input seemed to have been
> changed by Steve's recent patches, so I put it back the way it was
> before.
Hi,
Just got back from holiday and followed your fix trajectory for this.
Nice. Removing always_accept may remove the requirement for the
post-loop setting of ret to line_edit_input_done. I'll have to stare
at it some more though.
As for the placement of doecho, it was moved after accept_input since
doecho is not undoable. So, if accept_input fails repeatedly, the current
code could echo a character multiple times. However, given the
circumstances, I agree that moving doecho back is the correct thing to do
in the short term.
My next set of patches should remedy this by adding an echobuf that
will essentially make echo characters be read before the slave input.
Undoubtedly, someone will find a case where this isn't correct, but
for now I can't think of what that case may be.
Thank you, cgf, for taking time out of your holidays to look at this.
-steve
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Bug reporting: http://cygwin.com/bugs.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/
- Raw text -