Mail Archives: cygwin/2002/11/26/14:54:04
On Tue, Nov 26, 2002 at 12:42:28PM +0100, Ralf Habacker wrote:
>> > -----Original Message-----
>> > From: binutils-owner AT sources DOT redhat DOT com
>> > [mailto:binutils-owner AT sources DOT redhat DOT com]On Behalf Of Christopher
>> > Faylor
>> > Sent: Tuesday, November 26, 2002 2:42 AM
>> > To: Binutils; cygwin AT cygwin DOT com
>> > Subject: Re: [Patch] skipping import libraries for performance reasons -
>> > direct auto-import of dll's
>> >
>> >
>> > On Mon, Nov 25, 2002 at 11:50:13PM +0100, Ralf Habacker wrote:
>> > >Chuck Wilson wrote:
>> > >>Minor nit about patch format: watch out for your tab/indentation. It
>> > >>doesn't match the surrounding text in many cases.
>> > >
>> > >Okay. How are the tab width ?
>> >
>> > It's the standard 8 characters per tab. You also aren't adhering to GNU
>> > coding standards and a ChangeLog would be nice.
>> >
>> Okay, I will try.
>
>Hmmh, there are problems. In pe-dll.c for example, several lines are indented
>with tabs, other with tabs and spaces and other with two spaces for each
>indention level. Which should I use ?
>
>The easiest way for such problems seems to me to suggest an indent command line,
>which everyone who is going to build a patch could apply before to ensure the
>standards. Is anyone there who can provide such an indent command line ?
I'm sure there is a suggestion on the FSF site. I'm not sure why it is so
hard to discern from the code, though. Just make sure your code lines up
like everything else. If you can't figure out how to make the tabs work
then use spaces. This really isn't worth spending a lot of email time on.
cgf
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Bug reporting: http://cygwin.com/bugs.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/
- Raw text -