Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Message-ID:	<01f101c20339$08999fa0$42a18c09@wdg.uk.ibm.com>
From:	"Max Bowsher" <maxb AT ukf DOT net>
To:	<cygwin AT cygwin DOT com>
Subject:	Setup 2.243 - Crash isolated
Date:	Fri, 24 May 2002 16:36:38 +0100
MIME-Version:	1.0
X-Priority:	3
X-MSMail-Priority:	Normal
X-MimeOLE:	Produced By Microsoft MimeOLE V6.00.2600.0000

I have isolated the crash I was getting. It was similar to what Pavel suggested,
but in a different place.

It is caused by rfc1738_do_escape calling strlen(url) when url is NULL.

Here is a stack trace:

#0  rfc1738_do_escape (url=0x0, encode_reserved=1) at ../rfc1738.cc:82
#1  0x004340ac in rfc1738_escape_part (url=@0x125a238) at ../rfc1738.cc:195
#2  0x0040c5cf in check_for_cached (pkgsource=@0x11d8ed8) at ../download.cc:91
#3  0x004043c6 in scan_downloaded_files () at ../choose.cc:471
#4  0x004045d1 in ChooserPage::OnInit (this=0x23fb60) at ../choose.cc:517

A kludge in rfc1738_do_escape avoids the crash, and allows setup to continue.

I will need to study setup some more before I can track this down to its root
cause.

Max.


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

- Raw text -