Mail Archives: cygwin/2001/06/10/20:03:24
Jason,
If you've been following the subthread between Robert Collins and I,
then you understand why I haven't pushed too hard to get the readline
patch into Chet's official sources. I really don't want to fight that
battle -- and then have to fight to get it removed if Paul Sokolovsky's
modified binutils works as advertised.
So, I guess we'll just have to live with the status quo for a the time
being, unless you want to take over readline, 200k patch and all.
--Chuck
"Charles S. Wilson" wrote:
>
> Jason Tishler wrote:
> > > Yes, would you like to take over maintainership for the cygwin-readline
> > > package?
> >
> > Boy did I step in it! :,)
> >
> > I have been contemplating the acceptance of this role, but to be honest
> > I don't relish the responsibility given that the Cygwin specific patch
> > is almost 200K.
>
> Take a look at the patch; there are very few if any *substantive*
> changes in the library. It's almost entirely changing
>
> int
> my_function (args)
> to
> READLINE_EXPORT(int,my_function) (args)
>
> and
>
> extern int foobar;
> to
> READLINE_EXPORT_VAR(int) foobar;
>
> However, since there are SO MANY entry points in this library, that adds
> up to a lot of changes. The reason the 4.1-4.2 transition was so
> painful was because Chet cleaned up a lot of the definitions, adding
> 'const' qualifiers to many of the function arguments -- and thus, the
> old patch wouldn't apply. (I don't think he's going to do that
> again...)
>
> > Have you approached Chet regarding acceptance of your
> > patch into readline CVS?
>
> I did, at one point. He was unenthusiastic since it really uglifies the
> source. I will try again.
>
> > If Chet is willing to accept your patch,
> > then I could probably be convinced.
>
> Okay. Thanks,
> Chuck
>
> --
> Want to unsubscribe from this list?
> Check out: http://cygwin.com/ml/#unsubscribe-simple
--
Want to unsubscribe from this list?
Check out: http://cygwin.com/ml/#unsubscribe-simple
- Raw text -