Mailing-List:	contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin/>
List-Post:	<mailto:cygwin AT sources DOT redhat DOT com>
List-Help:	<mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-owner AT sources DOT redhat DOT com
Delivered-To:	mailing list cygwin AT sources DOT redhat DOT com
Message-ID:	<3B1DADBE.811853DD@ece.gatech.edu>
Date:	Wed, 06 Jun 2001 00:12:46 -0400
From:	"Charles S. Wilson" <cwilson AT ece DOT gatech DOT edu>
X-Mailer:	Mozilla 4.77 [en] (WinNT; U)
X-Accept-Language:	en
MIME-Version:	1.0
To:	Jason Tishler <Jason DOT Tishler AT dothill DOT com>
CC:	Cygwin Users <cygwin AT cygwin DOT com>
Subject:	Re: [avail for test] readline-4.2-1
References:	<20010605113203 DOT B490 AT dothill DOT com> <3B1CFE49 DOT 20A885CA AT yahoo DOT com> <3B1D94F9 DOT F6FADE8F AT ece DOT gatech DOT edu> <20010605225519 DOT B3095 AT dothill DOT com>

Jason Tishler wrote:
> > Yes, would you like to take over maintainership for the cygwin-readline
> > package?
> 
> Boy did I step in it! :,)
> 
> I have been contemplating the acceptance of this role, but to be honest
> I don't relish the responsibility given that the Cygwin specific patch
> is almost 200K.  

Take a look at the patch; there are very few if any *substantive*
changes in the library. It's almost entirely changing

int
my_function (args)
to
READLINE_EXPORT(int,my_function) (args)

and

extern int foobar;
to
READLINE_EXPORT_VAR(int) foobar;

However, since there are SO MANY entry points in this library, that adds
up to a lot of changes.  The reason the 4.1-4.2 transition was so
painful was because Chet cleaned up a lot of the definitions, adding
'const' qualifiers to many of the function arguments -- and thus, the
old patch wouldn't apply.  (I don't think he's going to do that
again...)

> Have you approached Chet regarding acceptance of your
> patch into readline CVS?  

I did, at one point.  He was unenthusiastic since it really uglifies the
source.  I will try again.

> If Chet is willing to accept your patch,
> then I could probably be convinced.

Okay.  Thanks,
Chuck

--
Want to unsubscribe from this list?
Check out: http://cygwin.com/ml/#unsubscribe-simple

- Raw text -