Mailing-List:	contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin/>
List-Post:	<mailto:cygwin AT sources DOT redhat DOT com>
List-Help:	<mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-owner AT sources DOT redhat DOT com
Delivered-To:	mailing list cygwin AT sources DOT redhat DOT com
Message-ID:	<3B0BA9DE.71539C6F@certum.pl>
Date:	Wed, 23 May 2001 14:15:26 +0200
From:	Jacek Trzcinski <jacek AT certum DOT pl>
Reply-To:	jacek AT certum DOT pl
X-Mailer:	Mozilla 4.7 [en] (WinNT; U)
X-Accept-Language:	en,pdf
MIME-Version:	1.0
To:	Corinna Vinschen <cygwin AT cygwin DOT com>
Subject:	Re: Serial programming patch
References:	<3B0A5B48 DOT D8508D38 AT certum DOT pl> <20010522215504 DOT J10118 AT cygbert DOT vinschen DOT de> <3B0B6AF3 DOT 818DBC AT certum DOT pl> <20010523103252 DOT N10118 AT cygbert DOT vinschen DOT de>

Hi Corrina,
I would not like bother You too much so I hope it is my last e-mail
today.
I created sources (with Your little help - thanks, I utilized
os_being_run) at last
are conforming to GNU coding. I also created my ChangeLog file.
What concerns signing a copyright assignment form - is it really
necessary ?
As I have read I have to send letter via normal mail, so I guess a lot
of time
may pass by I will get any response. Am I understand that until I will
not get
response from Red Hat I shouldn't send my patch ?
Jacek
P.S.
I have just subscribed to cygwin-patches list so I will send our
conversation concerning
ioctl codes and /dev... there.



Corinna Vinschen wrote:
> 
> On Wed, May 23, 2001 at 09:46:59AM +0200, Jacek Trzcinski wrote:
> > Hi Corinna,
> > I see it will be cost a little pain.
> > What concerns Your 3-rd remark (code not conforming GNU standard) is it
> > enough to
> > transform my sources utilizing indent.exe ?. If so, what switches should
> > I use ?
> 
> GNU indent does what it should do without switches. The GNU coding
> standard is the default. However, I suggest to change your patched
> sources by hand since there are two problems with indent. On one
> hand it's sometimes not that clever when indenting C++ sources and
> - most important - if you indent all concerned files they will be
> reformated everywhere and your patch will include parts which you
> never touched.
> 
> Corinna
> 
> > I have two remarks I forgot mention about in my previous e-mail.
> >
> > To read input queue there should be use constant FIONREAD (information
> > taken from different sources) but cygwin occupy it for socket software
> > !(it is macro). Constant TIOCINQ I have
> > taken from linux where it is equal FIONREAD(FIONREAD is not occupied in
> > linux like in cygwin).
> 
> I see. You should be able to use it anyway by including asm/socket.h.
> The macro expands to a constant expression. I understand that including
> asm/socket.h seems to make not much sense. Probably we should create
> a asm/ioctls.h file like in Linux.
> 
> Anyway, may I suggest to discuss that in cygwin-patches AT cygwin DOT com?
> 
> > Next matter concerns device name convention. In cygwin one may use
> > /dev/com1 or /dev/ttyS1
> > and so on. (what for is utilizing /dev/comx I do not know - it is not
> > portable to linux).
> 
> Good ol' COM...
> 
> > I think also that number of devices should start from 0 not from 1
> > (/dev/ttyS0 and so on) like in linux because again it is not portable.
> > What is Your opinion ?
> 
> As above: Let's discuss that in cygwin-patches AT cygwin DOT com.
> 
> Corinna
> 
> --
> Corinna Vinschen                  Please, send mails regarding Cygwin to
> Cygwin Developer                                mailto:cygwin AT cygwin DOT com
> Red Hat, Inc.
> 
> --
> Want to unsubscribe from this list?
> Check out: http://cygwin.com/ml/#unsubscribe-simple

--
Want to unsubscribe from this list?
Check out: http://cygwin.com/ml/#unsubscribe-simple

- Raw text -