Mailing-List:	contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin/>
List-Post:	<mailto:cygwin AT sources DOT redhat DOT com>
List-Help:	<mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-owner AT sources DOT redhat DOT com
Delivered-To:	mailing list cygwin AT sources DOT redhat DOT com
Date:	Tue, 22 May 2001 21:55:04 +0200
From:	Corinna Vinschen <cygwin AT cygwin DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: Serial programming patch
Message-ID:	<20010522215504.J10118@cygbert.vinschen.de>
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<3B0A5B48 DOT D8508D38 AT certum DOT pl>
Mime-Version:	1.0
User-Agent:	Mutt/1.2.5i
In-Reply-To:	<3B0A5B48.D8508D38@certum.pl>; from jacek@certum.pl on Tue, May 22, 2001 at 02:27:52PM +0200

Thanks for your work. Unfortunately, we can't use it for three
reasons:

- The patch is too long to use it without you signing a copyright
  assignment form. Look on http://cygwin.com/contrib.html for details.

- A ChangeLog entry is missing. Please add a plain ChangeLog entry to
  your posting like the ones you can see in the Cygwin ChangeLog file.

- Your code is not conforming to the GNU coding standard.
  Look on http://www.gnu.org/prep/standards_toc.html for details
  (or just compare with the other code in Cygwin).

Then you're adding a member to fhandler_serial to check for the OS
that way:

	osVersion=GetVersion();
	[...]
	if(!(osVersion&0x80000000))

while Cygwin already has a way to check that without the need to
add a member:

	if (os_being_run == winNT)  // or win95, win98, winME

Btw, there's a special mailing list cygwin-patches AT cygwin DOT com to send
and discuss patches to Cygwin. If you want to contribute to the project
it would have some advantages to subscribe to that list and to the list
cygwin-developers AT cygwin DOT com as well.

I hope I didn't discourage you too much. Each contributor (and Chris and
I began as contributors, too) had to go through this.

Corinna

On Tue, May 22, 2001 at 02:27:52PM +0200, Jacek Trzcinski wrote:
> Hi !,
> Here is my patch to serial device. I implemented ioctl function which
> makes possible
> [...]

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin AT cygwin DOT com
Red Hat, Inc.

--
Want to unsubscribe from this list?
Check out: http://cygwin.com/ml/#unsubscribe-simple

- Raw text -