Mailing-List:	contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin/>
List-Post:	<mailto:cygwin AT sources DOT redhat DOT com>
List-Help:	<mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-owner AT sources DOT redhat DOT com
Delivered-To:	mailing list cygwin AT sources DOT redhat DOT com
Message-ID:	<3AA8EE6F.8210C96E@ece.gatech.edu>
Date:	Fri, 09 Mar 2001 09:53:35 -0500
From:	"Charles S. Wilson" <cwilson AT ece DOT gatech DOT edu>
X-Mailer:	Mozilla 4.75 [en] (WinNT; U)
X-Accept-Language:	en
MIME-Version:	1.0
To:	d94-llu AT nada DOT kth DOT se
CC:	cygwin AT sources DOT redhat DOT com
Subject:	Re: wget bug?
References:	<984140068 DOT 18214 DOT ezmlm AT sources DOT redhat DOT com> <984141109 DOT 3aa8cd35d281b AT mail1 DOT nada DOT kth DOT se>

Thanks for the patch.  However, you should probably do something like:
#if defined(WIN32) || defined(__CYGWIN__)
  your code
#endif

Can you regenerate the patch with those changes and send it both to me,
and to the official wget maintainer or mailing list (go to www.gnu.org
to find out how to report patches for wget).

Thanks,
--Chuck

d94-llu AT nada DOT kth DOT se wrote:
> 
> I found where to change all ? to _.
> 
> This is an ugly solution not checking that FS is NTFS or anything such. Also
> other protocols (ftp) should be fixed.
> 
> Small patch:
> 
> /usr/local/src/wget-1.6/src$ diff http.c http2.c
> 749a750,762
> >       /* Windows doesn't (always) allow /\:*?"<>| in filenames,
> >          Change to _ and pray for none name-clashes.
> >          But / and \ are path-indicators. Leave them.
> >          Leif Lundgren, 2001-03-09
> >        */
> >       {
> >               int i;
> >               const char bad_chars[] = ":*?\"<>|";
> >               for ( i=0; u->local[i] != '\0'; i++ )
> >                       if ( strchr( bad_chars, u->local[i] ) != NULL )
> >                               u->local[i] = '_';
> >       }
> >
> 
> At  Fri, 09 Mar 2001 12:59:12 +0100 (MET) Leif Lundgren wrote:
> >
> > I think I have discoved a bug in the port of wget. (Version 1.6)
> >
> > If you download an url containing a '?' you get an error. wget tries to
> > create a file containing a '?'.
> >
> > Example:
> > wget "http://search.altavista.com/cgi-bin/query?
> > q=cygwin&kl=XX&pg=q&Translate=on"
> >
> > Does the rest of the world have the same problem?
> >
> > Regards
> >   Leif Lundgren
> >
> >
> > ---------
> > System is Windows 2000, NTFS volume.
> >
> >     Cygwin DLL version info:
> >         dll major: 1001
> >         dll minor: 8
> >         dll epoch: 19
> >         dll bad signal mask: 19005
> >         dll old termios: 5
> >         dll malloc env: 28
> >         api major: 0
> >         api minor: 34
> >         shared data: 3
> >
> 
> --
> Want to unsubscribe from this list?
> Check out: http://cygwin.com/ml/#unsubscribe-simple

--
Want to unsubscribe from this list?
Check out: http://cygwin.com/ml/#unsubscribe-simple

- Raw text -