Mailing-List:	contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin/>
List-Post:	<mailto:cygwin AT sources DOT redhat DOT com>
List-Help:	<mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-owner AT sources DOT redhat DOT com
Delivered-To:	mailing list cygwin AT sources DOT redhat DOT com
Date:	Wed, 8 Nov 2000 22:31:08 -0500
From:	Christopher Faylor <cgf AT redhat DOT com>
To:	"'cygwin AT sources DOT redhat DOT com'" <cygwin AT sources DOT redhat DOT com>
Subject:	Re: Case-insensitive globbing (was RE: Cygnus question)
Message-ID:	<20001108223108.A7887@redhat.com>
Reply-To:	cygwin AT sources DOT redhat DOT com
Mail-Followup-To:	"'cygwin AT sources DOT redhat DOT com'" <cygwin AT sources DOT redhat DOT com>
References:	<F10D23B02E54D011A0AB0020AF9CEFE988F9AF AT lynx DOT ceddec DOT com>
Mime-Version:	1.0
User-Agent:	Mutt/1.3.6i
In-Reply-To:	<F10D23B02E54D011A0AB0020AF9CEFE988F9AF@lynx.ceddec.com>; from btown@ceddec.com on Fri, Nov 03, 2000 at 05:24:50PM -0500

On Fri, Nov 03, 2000 at 05:24:50PM -0500, Town, Brad wrote:
>> Thanks for the patch but this really needs to be under the 
>> control of a
>> CYGWIN setting.  We already have CYGWIN=glob.  Maybe something like
>> CYGWIN=glob:ignorecase would be appropriate.
>
>Here are patches to dcrt0.cc, environ.cc, and glob.c to do just that.
>
>Note that ignore_case_with_glob is an int, not a BOOL like it should be.  I
>did that because I'm late getting home.
>
>For future reference, is the way I did it The Right Way?

Sorry I didn't respond before this.

A lot of this was right.  The environ.cc and dcrt0.cc parts looked ok.

The changes to glob.c were obvious but I'm not sure that they are correct.
The problem is that the glob() function is exported from the DLL.  I don't
know if its operation should be under the control of the CYGWIN environment
variable when it is called by the program directly.  I don't think it should
be actually.

Maybe all that you need is clear the "ignore_case_with_glob" after dcrt0.cc
has called glob.  Then glob() would revert to its normal operation.

I'd appreciate it if you would test that glob's operation when called from
a program is unchanged, too.

So, this was very close.  If I had thought of and enunciated these issues before
I'm sure it would have been perfect.

Thanks,
cgf

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe AT sourceware DOT cygnus DOT com

- Raw text -