delorie.com/archives/browse.cgi   search  
Mail Archives: cygwin/2000/10/27/08:33:52

Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Message-ID: <17B78BDF120BD411B70100500422FC6309E147@IIS000>
From: Bernard Dautrevaux <Dautrevaux AT microprocess DOT com>
To: "'Jimen Ching'" <jching AT flex DOT com>, cygwin AT sourceware DOT cygnus DOT com
Subject: RE: [patch] ambiguous else
Date: Fri, 27 Oct 2000 14:21:12 +0200
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2650.21)

> -----Original Message-----
> From: Jimen Ching [mailto:jching AT flex DOT com]
> Sent: Friday, October 27, 2000 6:53 AM
> To: cygwin AT sourceware DOT cygnus DOT com
> Subject: [patch] ambiguous else
> 
> 
> Hi all,
> 
> Can someone verify that the following patch is needed.
> 
> Also, in exceptions.cc, there is a comment in interrupt_setup 
> which says
> it is not multi-thread aware.  I am running into a strange 
> problem where I
> see an error about "couldn't send signal 14" and "wait for 
> sig_complete
> event failed, ..."  Are these related?  Can someone give me 
> some hints as
> to where to start looking if I want to know why these 
> messages are showing
> up?  Thanks.
> 
> --jc
> 
> --------------------------------------------------------------------
> diff -u -r1.51 sigproc.cc
> --- sigproc.cc	2000/10/23 20:50:36	1.51
> +++ sigproc.cc	2000/10/26 03:47:13
> @@ -1121,10 +1121,12 @@
>         * this thread should terminate.
>         */
>        if (rc == WAIT_TIMEOUT)
> +	{
>  	  if (!sig_loop_wait)
>  	    break;			// Exiting
>  	  else
>  	    continue;
> +	}
>  
>        if (rc == WAIT_FAILED)
>  	{
> 


These are not *needed*, but having them avoids anybody to wonder if the code
is doing this or that...

BTW, if you add the braces, you can even suppress the 'else' :-)

--------------------------------------------
Bernard Dautrevaux
Microprocess Ingenierie
97 bis, rue de Colombes
92400 COURBEVOIE
FRANCE
Tel:	+33 (0) 1 47 68 80 80
Fax:	+33 (0) 1 47 88 97 85
e-mail:	dautrevaux AT microprocess DOT com
		b DOT dautrevaux AT usa DOT net
-------------------------------------------- 

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe AT sourceware DOT cygnus DOT com

- Raw text -


  webmaster     delorie software   privacy  
  Copyright © 2019   by DJ Delorie     Updated Jul 2019