Mailing-List:	contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin/>
List-Post:	<mailto:cygwin AT sources DOT redhat DOT com>
List-Help:	<mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-owner AT sources DOT redhat DOT com
Delivered-To:	mailing list cygwin AT sources DOT redhat DOT com
Message-ID:	<20000911165833.22893.qmail@web2102.mail.yahoo.com>
Date:	Mon, 11 Sep 2000 09:58:33 -0700 (PDT)
From:	Kevin Lilly <tea41 AT yahoo DOT com>
Subject:	Re: Make bug and patch
To:	cygwin AT sources DOT redhat DOT com
MIME-Version:	1.0

--0-150122846-968691513=:19971
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline


So I jumped the gun a bit.  It turns out that my solution didn't cover
one additional case.  When I got into the office this morning and ran
our project against my new make executable there was one Makefile that
crapped out.  This was a different file than the previous Makefile
which had problems.  So when I looked at it I found that I had one
additional character in a continued line.  This meant that the CRLF was
being chopped off in readline.  Previously I had fixed the case where
just the LF was being seperated.

I've attached a new diff file.  This is based against the original
source; not the change that we put in over the weekend; though the
differences are small.  Take a look at it and make sure it looks
reasonable.

Thanks again and sorry for not testing out the first change enough. 
Hate to make you duplicate work.

Kevin


--- Chris Faylor <cgf AT cygnus DOT com> wrote:
> Thanks for the patch.  It looks reasonable so I wrote a ChangeLog
> entry
> and installed it.
> 
> I'll probably make a new version of make available soon.  I've also
> upgraded make to 3.79.1.
> 
> I really appreciate your tracking down the problem.
> 
> cgf


__________________________________________________
Do You Yahoo!?
Yahoo! Mail - Free email you can access from anywhere!
http://mail.yahoo.com/
--0-150122846-968691513=:19971
Content-Type: application/x-unknown; name="read.c-patch"
Content-Transfer-Encoding: base64
Content-Description: read.c-patch
Content-Disposition: attachment; filename="read.c-patch"

LS0tIHJlYWQub3JpZy5jCVNhdCBKdW4gMjQgMjE6MzI6MTAgMjAwMAorKysg
cmVhZC5jCU1vbiBTZXAgMTEgMTE6MTU6MjkgMjAwMApAQCAtMjE3NSw2ICsy
MTc1LDIwIEBAIHJlYWRsaW5lIChsaW5lYnVmZmVyLCBzdHJlYW0sIGZsb2Nw
KQogICAgICAgKytubGluZXM7CiAKICNpZiBkZWZpbmVkKFdJTjMyX09SX0NZ
R1dJTikgfHwgZGVmaW5lZChfX01TRE9TX18pCisgICAgICBpZiAoKGxlbiA9
PSAxIHx8IGxlbiA9PSAyKSAmJiBwID4gYnVmZmVyKQorI2Vsc2UKKyAgICAg
IGlmIChsZW4gPT0gMSAmJiBwID4gYnVmZmVyKQorI2VuZGlmCisJICAvKiBQ
IGlzIHBvaW50aW5nIGF0IGEgbmV3bGluZSBhbmQgaXQncyB0aGUgYmVnaW5u
aW5nIG9mCisJICAgICB0aGUgYnVmZmVyIHJldHVybmVkIGJ5IHRoZSBsYXN0
IGZnZXRzIGNhbGwuICBIb3dldmVyLAorCSAgICAgaXQgaXMgbm90IG5lY2Vz
c2FyaWx5IHRoZSBiZWdpbm5pbmcgb2YgYSBsaW5lIGlmIFAgaXMKKwkgICAg
IHBvaW50aW5nIHBhc3QgdGhlIGJlZ2lubmluZyBvZiB0aGUgaG9sZGluZyBi
dWZmZXIuCisJICAgICBJZiB0aGUgYnVmZmVyIHdhcyBqdXN0IGVubGFyZ2Vk
IChyaWdodCBiZWZvcmUgdGhlIG5ld2xpbmUpLAorCSAgICAgd2UgbXVzdCBh
Y2NvdW50IGZvciB0aGF0LCBzbyB3ZSBwcmV0ZW5kIHRoYXQgdGhlIHR3byBs
aW5lcworCSAgICAgd2VyZSBvbmUgbGluZS4gICovCisJICBsZW4gKz0gbGFz
dGxlbjsKKworI2lmIGRlZmluZWQoV0lOMzJfT1JfQ1lHV0lOKSB8fCBkZWZp
bmVkKF9fTVNET1NfXykKICAgICAgIC8qIENoZWNrIHRvIHNlZSBpZiB0aGUg
bGluZSB3YXMgcmVhbGx5IGVuZGVkIHdpdGggQ1JMRjsgaWYgc28gaWdub3Jl
CiAgICAgICAgICB0aGUgQ1IuICAqLwogICAgICAgaWYgKGxlbiA+IDEgJiYg
cFstMl0gPT0gJ1xyJykKQEAgLTIxODUsMTUgKzIxOTksNiBAQCByZWFkbGlu
ZSAobGluZWJ1ZmZlciwgc3RyZWFtLCBmbG9jcCkKICAgICAgICAgfQogI2Vu
ZGlmCiAKLSAgICAgIGlmIChsZW4gPT0gMSAmJiBwID4gYnVmZmVyKQotCS8q
IFAgaXMgcG9pbnRpbmcgYXQgYSBuZXdsaW5lIGFuZCBpdCdzIHRoZSBiZWdp
bm5pbmcgb2YKLQkgICB0aGUgYnVmZmVyIHJldHVybmVkIGJ5IHRoZSBsYXN0
IGZnZXRzIGNhbGwuICBIb3dldmVyLAotCSAgIGl0IGlzIG5vdCBuZWNlc3Nh
cmlseSB0aGUgYmVnaW5uaW5nIG9mIGEgbGluZSBpZiBQIGlzCi0JICAgcG9p
bnRpbmcgcGFzdCB0aGUgYmVnaW5uaW5nIG9mIHRoZSBob2xkaW5nIGJ1ZmZl
ci4KLQkgICBJZiB0aGUgYnVmZmVyIHdhcyBqdXN0IGVubGFyZ2VkIChyaWdo
dCBiZWZvcmUgdGhlIG5ld2xpbmUpLAotCSAgIHdlIG11c3QgYWNjb3VudCBm
b3IgdGhhdCwgc28gd2UgcHJldGVuZCB0aGF0IHRoZSB0d28gbGluZXMKLQkg
ICB3ZXJlIG9uZSBsaW5lLiAgKi8KLQlsZW4gKz0gbGFzdGxlbjsKICAgICAg
IGxhc3RsZW4gPSBsZW47CiAgICAgICBiYWNrc2xhc2ggPSAwOwogICAgICAg
Zm9yIChwMiA9IHAgLSAyOyAtLWxlbiA+IDA7IC0tcDIpCg==


--0-150122846-968691513=:19971
Content-Type: text/plain; charset=us-ascii

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe AT sourceware DOT cygnus DOT com
--0-150122846-968691513=:19971--

- Raw text -