Mailing-List:	contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-subscribe AT sourceware DOT cygnus DOT com>
List-Archive:	<http://sourceware.cygnus.com/ml/cygwin/>
List-Post:	<mailto:cygwin AT sourceware DOT cygnus DOT com>
List-Help:	<mailto:cygwin-help AT sourceware DOT cygnus DOT com>, <http://sourceware.cygnus.com/ml/#faqs>
Sender:	cygwin-owner AT sourceware DOT cygnus DOT com
Delivered-To:	mailing list cygwin AT sourceware DOT cygnus DOT com
Message-ID:	<779F20BCCE5AD31186A50008C75D997917173B@silldn_mail1.sanwaint.com>
From:	"Fifer, Eric" <EFifer AT sanwaint DOT com>
To:	cygwin AT sourceware DOT cygnus DOT com
Subject:	Re: [ANNOUNCEMENT] Updated: binutils-20000625.tar.gz
Date:	Thu, 29 Jun 2000 12:10:06 +0100
MIME-Version:	1.0
X-Mailer:	Internet Mail Service (5.5.2650.21)

------_=_NextPart_000_01BFE1BA.D011052A
Content-Type: text/plain;
	charset="iso-8859-1"


The dllwrap program in this release is broken.  Any attempt to
use it will fail with an error like:

  Cannot reallocate 1694498816 bytes after allocating 163866652 bytes

Attached is a patch that fixes the problem.  Basically,
dyn_string_append() was being used instead of dyn_string_append_cstr():

  dllwrap.c:860: warning: passing arg 2 of `dyn_string_append' from
incompatible pointer type
  ...

Regards,

Eric Fifer


------_=_NextPart_000_01BFE1BA.D011052A
Content-Type: application/octet-stream;
	name="dllwrap.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="dllwrap.patch"

--- binutils-20000625/binutils/dllwrap.c-	Sun Jun 25 02:52:52 2000=0A=
+++ binutils-20000625/binutils/dllwrap.c	Thu Jun 29 10:56:47 2000=0A=
@@ -857,10 +857,10 @@=0A=
   dlltool_cmdline =3D dyn_string_new (cmdline_len);=0A=
   if (verbose)=0A=
     {=0A=
-      dyn_string_append (dlltool_cmdline, " -v");=0A=
+      dyn_string_append_cstr (dlltool_cmdline, " -v");=0A=
     }=0A=
-  dyn_string_append (dlltool_cmdline, " --dllname ");=0A=
-  dyn_string_append (dlltool_cmdline, dll_name);=0A=
+  dyn_string_append_cstr (dlltool_cmdline, " --dllname ");=0A=
+  dyn_string_append_cstr (dlltool_cmdline, dll_name);=0A=
 =0A=
   for (i =3D 1; i < argc; ++i)=0A=
     {=0A=
@@ -868,10 +868,10 @@=0A=
         {=0A=
 	  char *arg =3D saved_argv[i];=0A=
           int quote =3D (strchr (arg, ' ') || strchr (arg, '\t'));=0A=
-	  dyn_string_append (dlltool_cmdline, =0A=
+	  dyn_string_append_cstr (dlltool_cmdline, =0A=
 	                     (quote) ? " \"" : " ");=0A=
-	  dyn_string_append (dlltool_cmdline, arg);=0A=
-	  dyn_string_append (dlltool_cmdline, =0A=
+	  dyn_string_append_cstr (dlltool_cmdline, arg);=0A=
+	  dyn_string_append_cstr (dlltool_cmdline, =0A=
 	                     (quote) ? "\"" : "");=0A=
 	}=0A=
     }=0A=
@@ -894,9 +894,9 @@=0A=
 	  break;=0A=
 	}=0A=
     }=0A=
-  dyn_string_append (driver_cmdline, driver_flags);=0A=
-  dyn_string_append (driver_cmdline, " -o ");=0A=
-  dyn_string_append (driver_cmdline, dll_file_name);=0A=
+  dyn_string_append_cstr (driver_cmdline, driver_flags);=0A=
+  dyn_string_append_cstr (driver_cmdline, " -o ");=0A=
+  dyn_string_append_cstr (driver_cmdline, dll_file_name);=0A=
 =0A=
   if (! entry_point || strlen (entry_point) =3D=3D 0)=0A=
     {=0A=
@@ -915,10 +915,10 @@=0A=
 	  break;=0A=
 	}=0A=
     }=0A=
-  dyn_string_append (driver_cmdline, " -Wl,-e,");=0A=
-  dyn_string_append (driver_cmdline, entry_point);=0A=
-  dyn_string_append (dlltool_cmdline, " --exclude-symbol=3D");=0A=
-  dyn_string_append (dlltool_cmdline, =0A=
+  dyn_string_append_cstr (driver_cmdline, " -Wl,-e,");=0A=
+  dyn_string_append_cstr (driver_cmdline, entry_point);=0A=
+  dyn_string_append_cstr (dlltool_cmdline, " --exclude-symbol=3D");=0A=
+  dyn_string_append_cstr (dlltool_cmdline, =0A=
                      (entry_point[0] =3D=3D '_') ? entry_point+1 : =
entry_point);=0A=
 =0A=
   if (! image_base_str || strlen (image_base_str) =3D=3D 0)=0A=
@@ -929,12 +929,12 @@=0A=
       image_base_str =3D tmpbuf;=0A=
     }=0A=
 =0A=
-  dyn_string_append (driver_cmdline, " -Wl,--image-base,");=0A=
-  dyn_string_append (driver_cmdline, image_base_str);=0A=
+  dyn_string_append_cstr (driver_cmdline, " -Wl,--image-base,");=0A=
+  dyn_string_append_cstr (driver_cmdline, image_base_str);=0A=
 =0A=
   if (verbose)=0A=
     {=0A=
-      dyn_string_append (driver_cmdline, " -v");=0A=
+      dyn_string_append_cstr (driver_cmdline, " -v");=0A=
     }=0A=
 =0A=
   for (i =3D 1; i < argc; ++i)=0A=
@@ -943,10 +943,10 @@=0A=
         {=0A=
 	  char *arg =3D saved_argv[i];=0A=
           int quote =3D (strchr (arg, ' ') || strchr (arg, '\t'));=0A=
-	  dyn_string_append (driver_cmdline, =0A=
+	  dyn_string_append_cstr (driver_cmdline, =0A=
 	                     (quote) ? " \"" : " ");=0A=
-	  dyn_string_append (driver_cmdline, arg);=0A=
-	  dyn_string_append (driver_cmdline, =0A=
+	  dyn_string_append_cstr (driver_cmdline, arg);=0A=
+	  dyn_string_append_cstr (driver_cmdline, =0A=
 	                     (quote) ? "\"" : "");=0A=
 	}=0A=
     }=0A=
@@ -963,15 +963,15 @@=0A=
 =0A=
       step_pre1 =3D dyn_string_new (1024);=0A=
 =0A=
-      dyn_string_append (step_pre1, dlltool_cmdline->s);=0A=
+      dyn_string_append_cstr (step_pre1, dlltool_cmdline->s);=0A=
       if (export_all)=0A=
 	{=0A=
-          dyn_string_append (step_pre1, " --export-all =
--exclude-symbol=3D");=0A=
-          dyn_string_append (step_pre1, =0A=
+          dyn_string_append_cstr (step_pre1, " --export-all =
--exclude-symbol=3D");=0A=
+          dyn_string_append_cstr (step_pre1, =0A=
 	  =
"_cygwin_dll_entry AT 12,DllMainCRTStartup AT 12,DllMain AT 12,DllEntryPoint AT 12")=
;=0A=
 	}=0A=
-      dyn_string_append (step_pre1, " --output-def ");=0A=
-      dyn_string_append (step_pre1, def_file_name);=0A=
+      dyn_string_append_cstr (step_pre1, " --output-def ");=0A=
+      dyn_string_append_cstr (step_pre1, def_file_name);=0A=
 =0A=
       for (i =3D 1; i < argc; ++i)=0A=
 	{=0A=
@@ -983,10 +983,10 @@=0A=
 	          && (arg[len-1] =3D=3D 'o' || arg[len-1] =3D=3D 'a'))=0A=
 		{=0A=
 		  int quote =3D (strchr (arg, ' ') || strchr (arg, '\t'));=0A=
-		  dyn_string_append (step_pre1,=0A=
+		  dyn_string_append_cstr (step_pre1,=0A=
 				     (quote) ? " \"" : " ");=0A=
-		  dyn_string_append (step_pre1, arg);=0A=
-		  dyn_string_append (step_pre1,=0A=
+		  dyn_string_append_cstr (step_pre1, arg);=0A=
+		  dyn_string_append_cstr (step_pre1,=0A=
 				     (quote) ? "\"" : "");=0A=
 		}=0A=
 	    }=0A=
@@ -998,8 +998,8 @@=0A=
       dyn_string_delete (step_pre1);=0A=
     }=0A=
 =0A=
-  dyn_string_append (dlltool_cmdline, " --def ");=0A=
-  dyn_string_append (dlltool_cmdline, def_file_name);=0A=
+  dyn_string_append_cstr (dlltool_cmdline, " --def ");=0A=
+  dyn_string_append_cstr (dlltool_cmdline, def_file_name);=0A=
 =0A=
   if (verbose)=0A=
     {=0A=
@@ -1036,18 +1036,18 @@=0A=
     dyn_string_t step1 =3D dyn_string_new (driver_cmdline->length =0A=
                                          + strlen (base_file_name)=0A=
 				         + 20);=0A=
-    dyn_string_append (step1, "-Wl,--base-file,");=0A=
+    dyn_string_append_cstr (step1, "-Wl,--base-file,");=0A=
     quote =3D (strchr (base_file_name, ' ') =0A=
              || strchr (base_file_name, '\t'));=0A=
-    dyn_string_append (step1, =0A=
+    dyn_string_append_cstr (step1, =0A=
 	               (quote) ? "\"" : "");=0A=
-    dyn_string_append (step1, base_file_name);=0A=
-    dyn_string_append (step1, =0A=
+    dyn_string_append_cstr (step1, base_file_name);=0A=
+    dyn_string_append_cstr (step1, =0A=
 	               (quote) ? "\"" : "");=0A=
     if (driver_cmdline->length)=0A=
       {=0A=
-        dyn_string_append (step1, " ");=0A=
-        dyn_string_append (step1, driver_cmdline->s);=0A=
+        dyn_string_append_cstr (step1, " ");=0A=
+        dyn_string_append_cstr (step1, driver_cmdline->s);=0A=
       }=0A=
 =0A=
     if (run (driver_name, step1->s))=0A=
@@ -1087,28 +1087,28 @@=0A=
                                          + strlen (exp_file_name)=0A=
 				         + 20);=0A=
 =0A=
-    dyn_string_append (step2, "--base-file ");=0A=
+    dyn_string_append_cstr (step2, "--base-file ");=0A=
     quote =3D (strchr (base_file_name, ' ') =0A=
              || strchr (base_file_name, '\t'));=0A=
-    dyn_string_append (step2, =0A=
+    dyn_string_append_cstr (step2, =0A=
 	               (quote) ? "\"" : "");=0A=
-    dyn_string_append (step2, base_file_name);=0A=
-    dyn_string_append (step2, =0A=
+    dyn_string_append_cstr (step2, base_file_name);=0A=
+    dyn_string_append_cstr (step2, =0A=
 	               (quote) ? "\" " : " ");=0A=
 =0A=
-    dyn_string_append (step2, "--output-exp ");=0A=
+    dyn_string_append_cstr (step2, "--output-exp ");=0A=
     quote =3D (strchr (exp_file_name, ' ') =0A=
              || strchr (exp_file_name, '\t'));=0A=
-    dyn_string_append (step2, =0A=
+    dyn_string_append_cstr (step2, =0A=
 	               (quote) ? "\"" : "");=0A=
-    dyn_string_append (step2, exp_file_name);=0A=
-    dyn_string_append (step2, =0A=
+    dyn_string_append_cstr (step2, exp_file_name);=0A=
+    dyn_string_append_cstr (step2, =0A=
 	               (quote) ? "\"" : "");=0A=
 =0A=
     if (dlltool_cmdline->length)=0A=
       {=0A=
-        dyn_string_append (step2, " ");=0A=
-        dyn_string_append (step2, dlltool_cmdline->s);=0A=
+        dyn_string_append_cstr (step2, " ");=0A=
+        dyn_string_append_cstr (step2, dlltool_cmdline->s);=0A=
       }=0A=
 =0A=
     if (run (dlltool_name, step2->s))=0A=
@@ -1131,27 +1131,27 @@=0A=
                                          + strlen (exp_file_name)=0A=
                                          + strlen (base_file_name)=0A=
 				         + 20);=0A=
-    dyn_string_append (step3, "-Wl,--base-file,");=0A=
+    dyn_string_append_cstr (step3, "-Wl,--base-file,");=0A=
     quote =3D (strchr (base_file_name, ' ') =0A=
              || strchr (base_file_name, '\t'));=0A=
-    dyn_string_append (step3, =0A=
+    dyn_string_append_cstr (step3, =0A=
 	               (quote) ? "\"" : "");=0A=
-    dyn_string_append (step3, base_file_name);=0A=
-    dyn_string_append (step3, =0A=
+    dyn_string_append_cstr (step3, base_file_name);=0A=
+    dyn_string_append_cstr (step3, =0A=
 	               (quote) ? "\" " : " ");=0A=
 =0A=
     quote =3D (strchr (exp_file_name, ' ') =0A=
              || strchr (exp_file_name, '\t'));=0A=
-    dyn_string_append (step3, =0A=
+    dyn_string_append_cstr (step3, =0A=
 	               (quote) ? "\"" : "");=0A=
-    dyn_string_append (step3, exp_file_name);=0A=
-    dyn_string_append (step3, =0A=
+    dyn_string_append_cstr (step3, exp_file_name);=0A=
+    dyn_string_append_cstr (step3, =0A=
 	               (quote) ? "\"" : "");=0A=
 =0A=
     if (driver_cmdline->length)=0A=
       {=0A=
-        dyn_string_append (step3, " ");=0A=
-        dyn_string_append (step3, driver_cmdline->s);=0A=
+        dyn_string_append_cstr (step3, " ");=0A=
+        dyn_string_append_cstr (step3, driver_cmdline->s);=0A=
       }=0A=
 =0A=
     if (run (driver_name, step3->s))=0A=
@@ -1172,34 +1172,34 @@=0A=
                                          + strlen (exp_file_name)=0A=
 				         + 20);=0A=
 =0A=
-    dyn_string_append (step4, "--base-file ");=0A=
+    dyn_string_append_cstr (step4, "--base-file ");=0A=
     quote =3D (strchr (base_file_name, ' ') =0A=
              || strchr (base_file_name, '\t'));=0A=
-    dyn_string_append (step4, =0A=
+    dyn_string_append_cstr (step4, =0A=
 	               (quote) ? "\"" : "");=0A=
-    dyn_string_append (step4, base_file_name);=0A=
-    dyn_string_append (step4, =0A=
+    dyn_string_append_cstr (step4, base_file_name);=0A=
+    dyn_string_append_cstr (step4, =0A=
 	               (quote) ? "\" " : " ");=0A=
 =0A=
-    dyn_string_append (step4, "--output-exp ");=0A=
+    dyn_string_append_cstr (step4, "--output-exp ");=0A=
     quote =3D (strchr (exp_file_name, ' ') =0A=
              || strchr (exp_file_name, '\t'));=0A=
-    dyn_string_append (step4, =0A=
+    dyn_string_append_cstr (step4, =0A=
 	               (quote) ? "\"" : "");=0A=
-    dyn_string_append (step4, exp_file_name);=0A=
-    dyn_string_append (step4, =0A=
+    dyn_string_append_cstr (step4, exp_file_name);=0A=
+    dyn_string_append_cstr (step4, =0A=
 	               (quote) ? "\"" : "");=0A=
 =0A=
     if (dlltool_cmdline->length)=0A=
       {=0A=
-        dyn_string_append (step4, " ");=0A=
-        dyn_string_append (step4, dlltool_cmdline->s);=0A=
+        dyn_string_append_cstr (step4, " ");=0A=
+        dyn_string_append_cstr (step4, dlltool_cmdline->s);=0A=
       }=0A=
 =0A=
     if (output_lib_file_name)=0A=
       {=0A=
-        dyn_string_append (step4, " --output-lib ");=0A=
-        dyn_string_append (step4, output_lib_file_name);=0A=
+        dyn_string_append_cstr (step4, " --output-lib ");=0A=
+        dyn_string_append_cstr (step4, output_lib_file_name);=0A=
       }=0A=
 =0A=
     if (run (dlltool_name, step4->s))=0A=
@@ -1225,16 +1225,16 @@=0A=
 				         + 20);=0A=
     quote =3D (strchr (exp_file_name, ' ') =0A=
              || strchr (exp_file_name, '\t'));=0A=
-    dyn_string_append (step5, =0A=
+    dyn_string_append_cstr (step5, =0A=
 	               (quote) ? "\"" : "");=0A=
-    dyn_string_append (step5, exp_file_name);=0A=
-    dyn_string_append (step5, =0A=
+    dyn_string_append_cstr (step5, exp_file_name);=0A=
+    dyn_string_append_cstr (step5, =0A=
 	               (quote) ? "\"" : "");=0A=
 =0A=
     if (driver_cmdline->length)=0A=
       {=0A=
-        dyn_string_append (step5, " ");=0A=
-        dyn_string_append (step5, driver_cmdline->s);=0A=
+        dyn_string_append_cstr (step5, " ");=0A=
+        dyn_string_append_cstr (step5, driver_cmdline->s);=0A=
       }=0A=
 =0A=
     if (run (driver_name, step5->s))=0A=


------_=_NextPart_000_01BFE1BA.D011052A
Content-Type: text/plain; charset=us-ascii

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe AT sourceware DOT cygnus DOT com
------_=_NextPart_000_01BFE1BA.D011052A--

- Raw text -