X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com X-CMAE-Analysis: v=2.4 cv=b8N3XvKx c=1 sm=1 tr=0 ts=5fde8831 a=+cj0cO56Fp8x7EdhTra87A==:117 a=vz7o70rkopUqcgApUuv7ag==:17 a=9+rZDBEiDlHhcck0kWbJtElFXBc=:19 a=IkcTkHD0fZMA:10 a=zTNgK-yGK50A:10 a=Mj1Xp5F7AAAA:8 a=a1KZgU7cAAAA:8 a=WmWdSZijAAAA:8 a=NYROA_cP8EdhzaABa2kA:9 a=QEXdDO2ut3YA:10 a=OCttjWrK5_uSHO_3Hkg-:22 a=ng0hpkU2jXKPaRTLMVYJ:22 a=TyhwexaRAurJGTW402Pw:22 X-SECURESERVER-ACCT: glimrick AT epilitimus DOT com Subject: Re: [geda-user] Problem with Guile 2.2.4 dependency for gEDA 1.10.1. To: geda-user AT delorie DOT com References: <20201219180603 DOT 22277 DOT qmail AT stuge DOT se> <20201219205836 DOT 23919 DOT qmail AT stuge DOT se> From: "Glenn (glimrick AT epilitimus DOT com) [via geda-user AT delorie DOT com]" Message-ID: Date: Sat, 19 Dec 2020 15:09:31 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.3 MIME-Version: 1.0 In-Reply-To: <20201219205836.23919.qmail@stuge.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - a2plcpnl0121.prod.iad2.secureserver.net X-AntiAbuse: Original Domain - delorie.com X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - epilitimus.com X-Get-Message-Sender-Via: a2plcpnl0121.prod.iad2.secureserver.net: authenticated_id: glimrick AT epilitimus DOT com X-Authenticated-Sender: a2plcpnl0121.prod.iad2.secureserver.net: glimrick AT epilitimus DOT com X-Source: X-Source-Args: X-Source-Dir: X-CMAE-Envelope: MS4xfLbZm96NCS8VmeaVdb5bO1Qas/Mz3nW8yoXnW89535FNdx2HjZG34zfwSXtqmsRDBxRWuKR+92pWDWYSew8VmCDM5Tr1pQmsAi9K1Ty4exmBU9cbbnbY GK1auWEwdj06OQI6cq2dm6NaLYfr7YauyEyz4hE5Vj2n19sW+5nDwMhZbpPMAihfv/AtEFnEaGnyJuFFAc/q5U6cNV6GRO1pPF/A6zV6vSv38a+F2MDHOIgz Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk Peter Stuge (peter AT stuge DOT se) [via geda-user AT delorie DOT com] wrote: > Glenn (glimrick AT epilitimus DOT com) [via geda-user AT delorie DOT com] wrote: >> And I would suggest a configure switch to allow use with guile-2.0 as >> well. The changes for 2.2 are minimal at this point. In time as the 2.2 >> dependency becomes more extensive and 2.0 usage declines the support can >> be dropped. I am willing to write the patch if needed. > Maybe the code could be made to support both, with or without the > help of configure. > > What would the patch for 2.0 need to change? > > > Kind regards > > //Peter > The relevant commit: > commit 8424e3d3dd3ee4447e15e6252d0ef426479e41af > Author: Roland Lutz > Date:   Sat Oct 17 19:52:56 2020 +0200 > >     Migrate to Guile 2.2 >      >     In Guile 2.2, the API function `scm_frame_procedure' has been replaced >     with `scm_frame_procedure_name', so only the name of the currently >     executed procedure can now be retrieved, not the procedure itself. >      >     Instead of using the procedure itself as a look-up key for the address >     of the corresponding Python callable, we now have to generate a unique >     name for each Guile procedure and use that as the key. According to the docs on my machine there is no 'scm_frame_procedure_name' function in 2.0. So if I understand correctly it is an either/or situation. Personally I have no problem with making 2.2 the default provided there is a means of overriding that default to allow for a migration path, something like $./configure --with-guile20 ... Yes it makes the code a bit messier for a while but it stops the bruhaha, and I've never known people to complain about having options. There are only 9 lines across two *.c files involved. Then a change to configure.ac to enable the switch. It should be possible to have configure detect which version of guile is available and then build accordingly. The reason I don't like that approach is that if for some reason, e.g. development, you have both versions available but want to use one of them specifically you can't. Glenn