X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com X-CMAE-Analysis: v=2.4 cv=YI9adTKx c=1 sm=1 tr=0 ts=5fc873a4 a=+cj0cO56Fp8x7EdhTra87A==:117 a=/N1Y5tmZ/4hGJ3X63IsiZw==:17 a=9+rZDBEiDlHhcck0kWbJtElFXBc=:19 a=IkcTkHD0fZMA:10 a=zTNgK-yGK50A:10 a=QzcoKnfMk7VpPAGGIAQA:9 a=QEXdDO2ut3YA:10 X-SECURESERVER-ACCT: glimrick AT epilitimus DOT com Subject: Re: [geda-user] SAB processing patches To: geda-user AT delorie DOT com References: <20201130220505 DOT 0AE4282C54FD AT turkos DOT aspodata DOT se> <7c75ed03-456c-b408-8b50-0448f6b3a04f AT epilitimus DOT com> <1b2c64b3-6a36-c1f3-dd54-bb583c6bea17 AT epilitimus DOT com> From: "Glenn (glimrick AT epilitimus DOT com) [via geda-user AT delorie DOT com]" Message-ID: <475f980e-fddd-60d1-9a02-a5bc5fb5805b@epilitimus.com> Date: Wed, 2 Dec 2020 21:11:55 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - a2plcpnl0121.prod.iad2.secureserver.net X-AntiAbuse: Original Domain - delorie.com X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - epilitimus.com X-Get-Message-Sender-Via: a2plcpnl0121.prod.iad2.secureserver.net: authenticated_id: glimrick AT epilitimus DOT com X-Authenticated-Sender: a2plcpnl0121.prod.iad2.secureserver.net: glimrick AT epilitimus DOT com X-Source: X-Source-Args: X-Source-Dir: X-CMAE-Envelope: MS4xfL1G6kWO9HkAGXxmuiwUVL/4LAa6R0xaWKhK4IemE48OLn+CKh/Oyoz9EiEI2KTbAKELkBKjmncfK5DY1+Ytm8YpziAHRnpBujrb5k7BoYBlYfEdCBmj //R54npVmRDz1pGCI4mo67m6+rDjTAhqnbvh/iTw2f2v8W57a61ZUeiGNhh1dVEH3uPP+KN7kw/A8IkZKune070DtnuONrwfr8FHI3I+p2BpGftpdNmEjygS Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk Roland, Roland Lutz wrote: > Ideally, you would push patches to a publicly visible Git repository > (self-hosted or Github, it doesn't really matter) and send a pull > request. Not the thing Github calls a pull request, but a mail > containing something along the lines of "please pull commit commit ID> from branch at repository " along with a > summary of your changes.  You can generate this in a standardized form > with "git request-pull". > working on this > Now we have the situation that I have a branch which contains the same > thing as, but is not ID-entical to, your branch, so you can't easily > pull my changes.  Instead, just cherry-pick the latest commit: > >     git checkout sab >     git cherry-pick 2de3373 > Thank you > > Yes, that's somewhat unfortunate.  I believe the "correct" way to > solve this is by separating the gnetlist "filter stages" (i.e., > slotting, hierarchy, packages) more cleanly and allowing the user to > specify a "filter pipeline" on the command line.  This would allow > handling refdes' much cleaner in SPICE backends by disabling the > "packaging" stage, and at the same time allow adding a custom "SAB" > stage. > > This has been on my mind for years, but so far, there have always been > more pressing issues. > If I understand correctly what you are describing could be done with an SAB exec script. It wouldn't be formalized but it could be accomplished. Kind of the whole impetus for SAB was to move the modification stage out of the backends making it backend independent. >> Valgrind shows several others, actually it shows lots but most are in >> linked libraries not in geda/gaf. I only fixed this one because I was >> right there working. > > Please do fix any issues you encounter.  Chances are nobody else will > touch that particular piece of code for some time, so if you don't fix > it, it won't be fixed. > Coming soon... I posted a patch for essentially all of the previous list. A few caveats are listed in the commit notes. What header do I need to include to use the _() translation bit in C code? I can't find it. Glenn