Mime-Version: 1.0 (Apple Message framework v753.1)
In-Reply-To: <20120903232403.GA19048@recycle.lbl.gov>
References: <20120903232403 DOT GA19048 AT recycle DOT lbl DOT gov>
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <753C3E35-FAE8-4650-B80C-E8478DBE44FD@jump-ing.de>
Content-Transfer-Encoding: 7bit
From: Markus Hitter <mah AT jump-ing DOT de>
Subject: Re: [geda-user] pcbdiff
Date: Tue, 4 Sep 2012 15:10:21 +0200
To: geda-user AT delorie DOT com
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
Precedence: bulk


Am 04.09.2012 um 01:24 schrieb Larry Doolittle:

> I messed around some with pcbdiff.  When it works, it's really nice!
> But I had problems with the image sizes mismatching between versions,
> even though the actual board size didn't change.  Those problems went
> away when I took out the --only-visible flag.
>
> While I was in there, I made the 200 dpi default over-ride-able with
> the environment variable PCBDIFF_DPI.  Patch attached.

Hello Larry,

first, thanks for the patch. Could you please open a bug on  
Launchpad, adding this patch and your test case? At the first glance  
I'm not sure wether this is the right fix, it might be a better idea  
to fix the reason for the differently sized PNG exports.


Markus

- - - - - - - - - - - - - - - - - - -
Dipl. Ing. (FH) Markus Hitter
http://www.jump-ing.de/