X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Subject: Re: PCB Use-after free bug [WAS: Re: [geda-user] PCB 2011-09-18 on WinXP - possible problems] From: Peter Clifton To: geda-user AT delorie DOT com Cc: Andrew Poelstra Date: Fri, 23 Sep 2011 01:37:18 +0100 In-Reply-To: <1316736122.23554.1.camel@localhost> References: <281807 DOT 1624 DOT 4103-26766-555981712-1316680336 AT seznam DOT cz> <1316734071 DOT 20531 DOT 15 DOT camel AT localhost> <1316736122 DOT 23554 DOT 1 DOT camel AT localhost> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-EkUOvFUbWXHkWgEniKEA" X-Mailer: Evolution 3.1.91- Message-ID: <1316738266.23554.23.camel@localhost> Mime-Version: 1.0 Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk --=-EkUOvFUbWXHkWgEniKEA Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2011-09-23 at 01:01 +0100, Peter Clifton wrote: > On Fri, 2011-09-23 at 00:27 +0100, Peter Clifton wrote: > >=20 > > Could you file this for me at: > >=20 > > http://launchpad.net/pcb/+filebug=20 >=20 > Never mind - I filed it myself: >=20 > https://bugs.launchpad.net/pcb/+bug/856909 And now fixed ;) Andrew - you might want to check and see if the Route Style selector part of this fix was correct. It is keeping pointers into the current "PCB" structure, and there is a certain delay between where the PCB is free'd, and actions are called to inform the GUI of this fact. (The problem here was an intervening call which suggested the route styles had changed - when there was no current board at all). Another band-aid type workaround would be to avoid free'ing the old PCB until we have a new one to replace it with - but if we have to do that, its rather admitting that our code is very very fragile! Best wishes, --=20 Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me) --=-EkUOvFUbWXHkWgEniKEA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAABAgAGBQJOe9S+AAoJEOo4D/b1x+QVFe4H/juql+Y1DIVKkaxZjPFPGeln JK+ITcDKQ35pKId1IJtE0yQ2XdTJ5GHqHruw7AhRKqS8jgfTsXLwtjajpEXUKc9y /hxgZRuS0FdZk+Kym9Rn/p2zluU6CFKt4r8PAbcR39tGJg+9Mp1RSxs3r8eHKhYs fOSdchV5bah8Le+s8MXNnSRyesviIvAIrbfdtw5macNljQVE/C/Lu67hlQfxvzYu ycOc3gqTdY58nUsy/2zPcv5TGY30UxppKBLBgfvcyJg8f4vqNtjt9DkQHfXOfK/s 2iES9B50rm/QwN1A4S+7Vca1M39fR3NoICom1GEWe5w6yrQrABvzNB6Wk71WLMI= =Yu+y -----END PGP SIGNATURE----- --=-EkUOvFUbWXHkWgEniKEA--