Message-ID: <509302C8.8050105@jump-ing.de>
Date: Fri, 02 Nov 2012 00:16:24 +0100
From: Markus Hitter <mah AT jump-ing DOT de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121011 Thunderbird/16.0.1
MIME-Version: 1.0
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] Makefile snippets in the pcb testsuite
References: <509279F6 DOT 9040702 AT jump-ing DOT de> <5092AEFF DOT 7020509 AT xs4all DOT nl>
In-Reply-To: <5092AEFF.7020509@xs4all.nl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: geda-user AT delorie DOT com

Am 01.11.2012 18:18, schrieb Bert Timmerman:
> Markus Hitter wrote:
>> the file Makefile.am inside the "golden" directory disappears.
>> Accordingly, ./autogen.sh && ./configure && make fails, because no
>>  Makefile is generated inside each of the "golden" directories.
>>
>> Am I expected to re-add these by hand? As far as I can see, it
>> simply adds an EXTRA-DIST for each result file to be verified.
>> Whatever the reason for these Makefiles is, it looks like tests are
>> expected to be run directly, without make.
>
> That is what I do, it strikes me as unwanted behaviour, and not
> according to the principles of least surprise ;-)

My tendency was more towards removing these Makefile templates, because 
when there's nothing to build, there's no need for a Makefile. Well, 
usually.

The not usual part is, there's a target "distdir", which apparently 
collects all available files into a directory "pcb-1.99z". Let's assume 
this does something useful, perhaps like running the tests after 
installation to check this installation. :-)

To avoid the foottrap of having these Makefile.am's deleted in the 
future, I've changed run_tests.sh to recreate this file, too:

http://git.geda-project.org/pcb/commit/?id=1ecf21543a30149b688b71ae8e0b66e5d714087a


Have fun,
Markus

-- 
- - - - - - - - - - - - - - - - - - -
Dipl. Ing. (FH) Markus Hitter
http://www.jump-ing.de/