X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp AT delorie DOT com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=OydCct/lEW+P476Kx2Pv0I0sw5qXWtWgb3kLAMQsrtw=;
        b=l3Vwjpq7mK04es0J590gUycyW+oh+V63DEg3LuS60xhu8LL6SsXBQclv7Age3a+0us
         UMEXA2PTx3uAeSzdGXziLUxjI0GmPQZv+m9fJEmVhjyq6NEC+eajlAPNrH6oCTjwGuXb
         UJbgyfafdtdW0NWIPxdEmlC734/4f8eAuq7DwgUG37cpWr+ceRuaOfDzivl1nvMOE9el
         bXAFYQjobPNgusYCA6/S1aT3J9l4GAb7pez23R7jaz6vc1cP0E3pg6hpZfjcGjyxhPEX
         aulR6BmqEuzPpCDrp4B8319XpNFVpeKkEjTTvkcRQvGbUnDJl7Re/8R1GBqfbmQw6eBb
         VmFA==
MIME-Version: 1.0
X-Received: by 10.107.12.93 with SMTP id w90mr12550343ioi.10.1431689988618;
 Fri, 15 May 2015 04:39:48 -0700 (PDT)
In-Reply-To: <83y4kqgq6s.fsf@gnu.org>
References: <CAA2C=vCgLHdH3BJxastGzUsJzhiRddytiYwB1MP_aaiiVpC4nA AT mail DOT gmail DOT com>
	<83k2wcjt8e DOT fsf AT gnu DOT org>
	<CAA2C=vB-YiGkyx5dJpa=hcBh0O4_NiEKh2tKm5OHyNX3vW7HsQ AT mail DOT gmail DOT com>
	<83bnhojnwh DOT fsf AT gnu DOT org>
	<CAA2C=vAEKFUktuYXGN_eYUEY0JuHQgXR_-q-N8xox=7PHPEqqw AT mail DOT gmail DOT com>
	<838ucsjnbl DOT fsf AT gnu DOT org>
	<CAA2C=vAK_T9ixd6YpNrd2LYL80Lau-Dbf+T5vo89AdYXS0WYOw AT mail DOT gmail DOT com>
	<83vbfvi3t1 DOT fsf AT gnu DOT org>
	<CAA2C=vAUa61rumTN9fyCDdtdGXzqfzZLdtz4Nw+8gWX-J-x0bg AT mail DOT gmail DOT com>
	<5554DF05 DOT 7020707 AT iki DOT fi>
	<CAA2C=vD_NVLdHdqz8RSUeU3VniwrQ85=fn+WD0+pxMbZziuyHg AT mail DOT gmail DOT com>
	<55556DFF DOT 8020400 AT iki DOT fi>
	<831tiii8vj DOT fsf AT gnu DOT org>
	<CAA2C=vA+iQLL5DcPASLq-1=SypW+iXrb_uoFN4fprgyE1m7ogg AT mail DOT gmail DOT com>
	<83y4kqgq6s DOT fsf AT gnu DOT org>
Date: Fri, 15 May 2015 14:39:48 +0300
Message-ID: <CAA2C=vCV7fqr-xjg5K7taLrBXx6Zuv7dB_pfx-AC+9D740mNgA@mail.gmail.com>
Subject: Re: bad pragma in dir.h? (and our structrure packing)
From: "Ozkan Sezer (sezeroz AT gmail DOT com)" <djgpp AT delorie DOT com>
To: djgpp AT delorie DOT com
Content-Type: text/plain; charset=UTF-8
Reply-To: djgpp AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

On 5/15/15, Eli Zaretskii (eliz AT gnu DOT org) <djgpp AT delorie DOT com> wrote:
>> Date: Fri, 15 May 2015 10:51:43 +0300
>> From: "Ozkan Sezer (sezeroz AT gmail DOT com)" <djgpp AT delorie DOT com>
>>
>> >  How can they produce such warnings
>> > without complaining about system header files, which are replete with
>> > unused typedefs?  At the very least, they should exempt header files,
>> > or at least system header files, which these are.
>> >
>> > So I find it hard to believe this could be a problem.
>> >
>>
>> IIUC, the warnings are only for local typedefs within function bodies
>> and not for global ones.
>
> That's reasonable, and doesn't affect our header files.
>
> Thanks.
>

OK then, added compile time assertions to coff.h (r1.9), dir.h (r1.9)
and dos.h (r1.17).

One thing remains:  IMO, we should either use pack pragmas or the
pack attribute, not both.  My first instinct is that we remove the only
appearance of the pack pragma from dir.h:  this way the headers
are compatible with gcc 2.91.66 (egcs, oldest I can test with). Can
not test or know compatibility with any older gcc version.

Or: we can remove the packed attributes and use only the pragmas.

Comments?

--
O.S.