X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
Date:	Sat, 24 Oct 2020 01:14:48 +0200 (CEST)
From:	Roland Lutz <rlutz AT hedmen DOT org>
To:	"Glenn (glimrick AT epilitimus DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
Subject:	Re: [geda-user] submitted a new patch
In-Reply-To:	<9b33084b-c548-a325-d14a-f6a4d659a596@epilitimus.com>
Message-ID:	<alpine.DEB.2.21.2010240053540.4744@nimbus>
References:	<14f9e862-8ee0-4432-23b6-06e94215baa4 AT epilitimus DOT com> <alpine DOT DEB DOT 2 DOT 21 DOT 2010120958150 DOT 2535 AT nimbus> <32bfe083-3604-b747-030a-48a13e2b1074 AT epilitimus DOT com> <alpine DOT DEB DOT 2 DOT 21 DOT 2010122312420 DOT 8245 AT nimbus> <7c133ba2-5b09-91f3-808f-9f444c625278 AT epilitimus DOT com>
	<alpine DOT DEB DOT 2 DOT 21 DOT 2010151343310 DOT 1527 AT nimbus> <aa7c0456-a606-be86-58c4-b8352cc66127 AT epilitimus DOT com> <alpine DOT DEB DOT 2 DOT 21 DOT 2010231526280 DOT 12318 AT nimbus> <A61C3EBE-CBAA-4951-874D-F215EB5515CA AT noqsi DOT com> <alpine DOT DEB DOT 2 DOT 21 DOT 2010231755200 DOT 11745 AT nimbus>
	<9b33084b-c548-a325-d14a-f6a4d659a596 AT epilitimus DOT com>
User-Agent:	Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version:	1.0
Reply-To:	geda-user AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	geda-user AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

On Fri, 23 Oct 2020, Glenn (glimrick AT epilitimus DOT com) [via 
geda-user AT delorie DOT com] wrote:
> 2. Not all spice simulators work the same. It is up to each
> implementation to decide if they want to use the first line, a specific
> .TITLE card, or both/either as ngspice does. For example my reference
> book on PSpice, fairly old so may be different now, requires the first
> line of the netlist to be the title. So spice-directive-1.sym would not
> produce a working netlist for such an implementation.

Hmm.  I don't like the idea of simulator idiosyncrasies being coded into 
the schematic; this just doesn't feel like the right way to do it.

How about changing the backend logic so the .TITLE directive, if there is 
any, is always placed first?  Would that work with all simulators?

Are there other cases where directives need to be placed in a particular 
order or place?


> 3. Yes it was a minor change, intentionally so, to let me get familiar
> with your process before I offered more substantial changes.

I didn't mean to criticize this; on the contrary, I think it's a good idea.


> 4. re: use of comment. I chose it as it seemed the most appropriate
> without adding a new attribute, and param (my first choice) was used for
> other things. If a new attribute would be preferred I have no problem
> with that. As a gneral plicy use specific attributes would however tend
> to lead to attribute bloat.

If there is no existing attribute that makes sense to use, and you feel 
like need to use an attribute, then it's fine to introduce a new one.  In 
any case, that's better than using a conceptually different attribute like 
"comment=".


> 5. I will not be heart broken if you decide to remove spice-title et al. :)

We'll see.  I think you have a point, so your contribution is likely to 
result in a change in one form or another.  And even if it didn't, having 
the kind of discussion we're in right now is an integral part of the 
process with which you're looking to familiarize yourself.


Roland

- Raw text -