Mail Archives: geda-user/2020/10/23/18:43:02

X-Authentication-Warning: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-CMAE-Analysis: v=2.3 cv=dpil9Go4 c=1 sm=1 tr=0
a=+cj0cO56Fp8x7EdhTra87A==:117 a=KfsEVROInO98a7V1GwzIHg==:17
a=9+rZDBEiDlHhcck0kWbJtElFXBc=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19
a=IkcTkHD0fZMA:10 a=afefHYAZSVUA:10 a=IlBfZrlZQX-vHui2fnoA:9 a=QEXdDO2ut3YA:10
X-SECURESERVER-ACCT: glimrick AT epilitimus DOT com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;; s=default; h=Content-Transfer-Encoding:Content-Type:
bh=ogU6lJSU/oqsLOEEcx8gMtLiKTXYXFXTBzT0Ji0Gsew=; b=Bxp7+T5B+c/xrYc8vy3+LmvaeO
Subject: Re: [geda-user] submitted a new patch
To: geda-user AT delorie DOT com
References: <14f9e862-8ee0-4432-23b6-06e94215baa4 AT epilitimus DOT com>
<alpine DOT DEB DOT 2 DOT 21 DOT 2010120958150 DOT 2535 AT nimbus>
<32bfe083-3604-b747-030a-48a13e2b1074 AT epilitimus DOT com>
<alpine DOT DEB DOT 2 DOT 21 DOT 2010122312420 DOT 8245 AT nimbus>
<7c133ba2-5b09-91f3-808f-9f444c625278 AT epilitimus DOT com>
<alpine DOT DEB DOT 2 DOT 21 DOT 2010151343310 DOT 1527 AT nimbus>
<aa7c0456-a606-be86-58c4-b8352cc66127 AT epilitimus DOT com>
<alpine DOT DEB DOT 2 DOT 21 DOT 2010231526280 DOT 12318 AT nimbus>
From: "Glenn (glimrick AT epilitimus DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
Message-ID: <>
Date: Fri, 23 Oct 2020 14:22:13 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
Firefox/60.0 SeaMonkey/2.53.3
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2010231526280.12318@nimbus>
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname -
X-AntiAbuse: Original Domain -
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain -
X-Get-Message-Sender-Via: authenticated_id: glimrick AT epilitimus DOT com
X-Authenticated-Sender: glimrick AT epilitimus DOT com
X-CMAE-Envelope: MS4wfBcKnQRen3hZDKoHfe/3ZJE2PjkuH/JfIa3WM3gOznqlATwP+w5tpogxE+YZx6ISSG0d0psL5BX4D/DqjBKhFVtEr4Ox4l0kuiqYblENHBK6/lPheul6
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com

Okay so the newline was there because of the debug message you removed.
It pushed the "Checking for title box" message to the next line. Once
that message was gone, yes the newline was unneeded.

I think the comment you are referring to was actually my rewrite of the
comment to include the fact that a specific title was permitted.  So
here I would argue that the change was relevant, but actually to the
previous patch that added the spice-title rather than this one.

In both cases not an issue for me.

Roland Lutz wrote:
> - The Guile patch contains unnecessary changes (adding a newline
> character to an unrelated debug message; removing an unrelated
> comment).  Patches should not contain any changes which are not
> immediately relevant to the issue the patch addresses.  If you think
> these changes would improve the project, please submit them as an
> individual patch.

- Raw text -

  webmaster     delorie software   privacy  
  Copyright 2019   by DJ Delorie     Updated Jul 2019