delorie.com/archives/browse.cgi   search  
Mail Archives: geda-user/2011/10/25/10:40:44

X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Tue, 25 Oct 2011 16:40:28 +0200
From: Gabriel Paubert <paubert AT iram DOT es>
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] Working with a 0.1mm grid
Message-ID: <20111025144028.GA8150@iram.es>
References: <CAKakQccb967HgSod6BeULhCSj7gE+L0oAVb=L82pGcOphJ7ohw AT mail DOT gmail DOT com> <20111021013756 DOT GE20384 AT malakian DOT lan> <CAKakQceJ8GBzX+jHqrhpD2D+-f1eoMqb7h5igJhHe-DuwQB1aQ AT mail DOT gmail DOT com> <20111021025514 DOT GF20384 AT malakian DOT lan> <1319310645 DOT 13417 DOT 8 DOT camel AT localhost> <201110230311 DOT p9N3BRr8005619 AT envy DOT delorie DOT com> <20111023185825 DOT GA24148 AT malakian DOT lan> <20111025120859 DOT GA5110 AT iram DOT es> <201110251224 DOT p9PCOk8L024200 AT envy DOT delorie DOT com> <20111025124846 DOT GA30093 AT iram DOT es>
MIME-Version: 1.0
In-Reply-To: <20111025124846.GA30093@iram.es>
User-Agent: Mutt/1.5.18 (2008-05-17)
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com

On Tue, Oct 25, 2011 at 02:48:46PM +0200, Gabriel Paubert wrote:
> On Tue, Oct 25, 2011 at 08:24:46AM -0400, DJ Delorie wrote:
> > 
> > Might be related to the new "snap to line intersections" feature.
> 
> Oops, I was wrong on the date. I had pulled early September but not
> compiled on my laptop, so make it May 19th (and I don't know how
> to obtain the git commit id).
> 
> By the way, when loading on my laptop a file recently created file on my
> desktop, I get a syntax error on line 8. Which reads:
> 
> Grid[0.1mm 0.0000 0.0000 1]
> 
> I believed backward compatibilty went further back in time...

Hmm, now I see that the parser was modified by Andrew around June 4th
to allow units. Don't ask me to understand bison/flex, I've always
had a gigantic impedance mismatch with that stuff. However git commit
750a1c57d85dbb82d704f9443055a783b5dca8eb includes the comment

    Bumped PCB_FILE_VERSION up to 20110703.

(slight typo: it should be 20110603).

I see that Andrew modified file.h to update this value, unfortunately
it is no more used in file.c; the following patch fixes it for now.

	Gabriel


diff --git a/src/file.c b/src/file.c
index 99ba274..c4620c9 100644
--- a/src/file.c
+++ b/src/file.c
@@ -157,22 +157,10 @@ static char *pcb_basename (char *p);
 
 */
 
-/* Hole[] in Polygon.  */
-#define PCB_FILE_VERSION_HOLES 20100606
-/* First version ever saved.  */
-#define PCB_FILE_VERSION_BASELINE 20091103
-
 int
 PCBFileVersionNeeded (void)
 {
-  ALLPOLYGON_LOOP (PCB->Data);
-  {
-    if (polygon->HoleIndexN > 0)
-      return PCB_FILE_VERSION_HOLES;
-  }
-  ENDALL_LOOP;
-
-  return PCB_FILE_VERSION_BASELINE;
+  return PCB_FILE_VERSION;
 }
 
 /* --------------------------------------------------------------------------- */

- Raw text -


  webmaster     delorie software   privacy  
  Copyright © 2019   by DJ Delorie     Updated Jul 2019